Disallow network access for provider tests

Disallow network access for provider tests

Outgoing network access is disabled for provider
tests. This lead to test failures for the maas
provider which were fixed. The "live" Joyent
provider tests were deleted as they never worked
properly anyway and other issues surfaced.

Part of the implementation removed the contained
LoggingSuite struct from the jujutests.LiveTests
and jujutests.Tests structs. The various provider
tests which embed these now contain BaseSuite.

https://code.launchpad.net/~wallyworld/juju-core/turn-on-network-isolation/+merge/219994

(do not edit description out of merge proposal)

[wallyworld, 2014-05-19 08:23:23]

Please take a look.

[axw, 2014-05-19 08:43:31]

LGTM

https://codereview.appspot.com/97560044/diff/1/environs/jujutest/livetests.go
File environs/jujutest/livetests.go (left):

https://codereview.appspot.com/97560044/diff/1/environs/jujutest/livetests.go...
environs/jujutest/livetests.go:46: testbase.LoggingSuite
Why remove this? Under the presumption that the embedding suite will also embed
BaseSuite? Fair, I guess.

https://codereview.appspot.com/97560044/diff/1/provider/openstack/local_test.go
File provider/openstack/local_test.go (right):

https://codereview.appspot.com/97560044/diff/1/provider/openstack/local_test....
provider/openstack/local_test.go:169: s.BaseSuite.AddSuiteCleanup(func(*gc.C) {
restoreFinishBootstrap() })
No need for the explicit BaseSuite qualifier

https://codereview.appspot.com/97560044/diff/1/utils/http.go
File utils/http.go (right):

https://codereview.appspot.com/97560044/diff/1/utils/http.go#newcode122
utils/http.go:122: if !ip.IsLoopback() {
ip will be nil if host is a hostname and not an IP, so this should probably be:
    if ip == nil || !ip.IsLoopback() {

[wallyworld, 2014-05-19 09:08:43]

https://codereview.appspot.com/97560044/diff/1/environs/jujutest/livetests.go
File environs/jujutest/livetests.go (left):

https://codereview.appspot.com/97560044/diff/1/environs/jujutest/livetests.go...
environs/jujutest/livetests.go:46: testbase.LoggingSuite
On 2014/05/19 08:43:31, axw wrote:
> Why remove this? Under the presumption that the embedding suite will also
embed
> BaseSuite? Fair, I guess.

Yes, the embedding suite must also embed BaseSuite. tl;dr; it makes sense to me
to treat LiveTests as purely a plugin of tests to run and the containing suite
does other necessary set up.

https://codereview.appspot.com/97560044/diff/1/provider/openstack/local_test.go
File provider/openstack/local_test.go (right):

https://codereview.appspot.com/97560044/diff/1/provider/openstack/local_test....
provider/openstack/local_test.go:169: s.BaseSuite.AddSuiteCleanup(func(*gc.C) {
restoreFinishBootstrap() })
On 2014/05/19 08:43:31, axw wrote:
> No need for the explicit BaseSuite qualifier

Done.

https://codereview.appspot.com/97560044/diff/1/utils/http.go
File utils/http.go (right):

https://codereview.appspot.com/97560044/diff/1/utils/http.go#newcode122
utils/http.go:122: if !ip.IsLoopback() {
On 2014/05/19 08:43:31, axw wrote:
> ip will be nil if host is a hostname and not an IP, so this should probably
be:
>     if ip == nil || !ip.IsLoopback() {

Done.