Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(986)

Issue 97540043: SDNV implementation for use in DTN protocols

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Ruben Martinez
Modified:
6 years, 5 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

SDNV implementation for use in DTN protocols

Patch Set 1 #

Total comments: 5

Patch Set 2 : changes to sdnv-test-suite #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -0 lines) Patch
A src/network/test/sdnv-test-suite.cc View 1 1 chunk +243 lines, -0 lines 0 comments Download
A src/network/utils/sdnv.h View 1 chunk +90 lines, -0 lines 1 comment Download
A src/network/utils/sdnv.cc View 1 chunk +116 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Tom Henderson
This looks good to me, once a few issues are addressed: - improved class doxygen ...
6 years, 5 months ago (2014-05-21 01:36:10 UTC) #1
Tommaso Pecorella
6 years, 5 months ago (2014-05-22 21:23:59 UTC) #2
I agree with Tom's comments. Plus, I'd remove the IsLast function.

https://codereview.appspot.com/97540043/diff/20001/src/network/utils/sdnv.h
File src/network/utils/sdnv.h (right):

https://codereview.appspot.com/97540043/diff/20001/src/network/utils/sdnv.h#n...
src/network/utils/sdnv.h:85: bool IsLast (uint8_t &val);
This function is used only once in the code.
Although it may be good for clarity, I'd suggest to remove it. Either it could
be declared private and inlined.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b