code review 9751043: encoding/asn1: harmonise error prefixes.

encoding/asn1: harmonise error prefixes.

This change ensures that error messages always start with "asn1: ".

[gedimitr, 2013-05-25 23:15:16]

I think that the package name will appear twice in a couple of cases (see
comments)

BRs,
Gerasimos

https://codereview.appspot.com/9751043/diff/4001/src/pkg/encoding/asn1/asn1.go
File src/pkg/encoding/asn1/asn1.go (right):

https://codereview.appspot.com/9751043/diff/4001/src/pkg/encoding/asn1/asn1.g...
src/pkg/encoding/asn1/asn1.go:50: err = SyntaxError{"asn1: invalid boolean"}
There should be no need to give the package name here, it is already provided by
SyntaxError.Error()

https://codereview.appspot.com/9751043/diff/4001/src/pkg/encoding/asn1/asn1.g...
src/pkg/encoding/asn1/asn1.go:63: err = SyntaxError{"asn1: invalid boolean"}
Same case also here

[agl1, 2013-05-29 14:58:45]

https://codereview.appspot.com/9751043/diff/4001/src/pkg/encoding/asn1/asn1.go
File src/pkg/encoding/asn1/asn1.go (right):

https://codereview.appspot.com/9751043/diff/4001/src/pkg/encoding/asn1/asn1.g...
src/pkg/encoding/asn1/asn1.go:50: err = SyntaxError{"asn1: invalid boolean"}
On 2013/05/25 23:15:16, gedimitr wrote:
> There should be no need to give the package name here, it is already provided
by
> SyntaxError.Error()

Thanks, you're quite correct! Will fix when I'm on the right computer.

[agl1, 2013-06-04 23:52:52]

Hello golang-dev@googlegroups.com, gedimitr@gmail.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[agl1, 2013-06-04 23:53:05]

*** Submitted as https://code.google.com/p/go/source/detail?r=1a43728b3f8f ***

encoding/asn1: harmonise error prefixes.

This change ensures that error messages always start with "asn1: ".

R=golang-dev, gedimitr
CC=golang-dev
https://codereview.appspot.com/9751043