Issue 97490043: Doc update for ADFS and Live authentication support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 97490043: Doc update for ADFS and Live authentication support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by Tanmay Vartak

Modified:
9 years, 10 months ago

Reviewers:
pjo, myk

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

Doc update for ADFS and Live authentication support

Patch Set 1 #

Total comments: 5

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
	M	src/overview.html	View		2 chunks	+30 lines, -0 lines	5 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Tanmay Vartak

On 2014/05/15 00:26:04, Tanmay Vartak wrote: Hi PJ, I think this might not be final ...

9 years, 11 months ago (2014-05-15 00:27:13 UTC) #2

Tanmay Vartak

typo https://codereview.appspot.com/97490043/diff/1/src/overview.html File src/overview.html (right): https://codereview.appspot.com/97490043/diff/1/src/overview.html#newcode76 src/overview.html:76: sharepoint.sts.endpoint=<b>https://adfs.exaple.com/adfs/services/trust/2005/usernamemixed adfs.example.com

9 years, 11 months ago (2014-05-15 00:28:03 UTC) #3

myk

9 years, 11 months ago (2014-05-15 22:57:54 UTC) #5

Just a few nits -- will say LGTM now so you can submit after correcting them.

https://codereview.appspot.com/97490043/diff/1/src/overview.html
File src/overview.html (right):

https://codereview.appspot.com/97490043/diff/1/src/overview.html#newcode65
src/overview.html:65: to SharePoint, then add these additional configurations
to be consistent, this should probably say "configuration options" rather than
"configurations"

https://codereview.appspot.com/97490043/diff/1/src/overview.html#newcode72
src/overview.html:72: to SharePoint, then add these additional configurations
here as well (and also lines 234 and 241)

https://codereview.appspot.com/97490043/diff/1/src/overview.html#newcode77
src/overview.html:77: </b>sharepoint.sts.realm=<b>urn:myserver:sharepoint or
https://yoursharepoint.example.com/_trust</b></pre>
consider not boldfacing the "or" -- that is,
<b>urn:myserver:sharepoint</b> or
<b>https://yoursharepoint.example.com/_trust</b>

https://codereview.appspot.com/97490043/diff/1/src/overview.html#newcode246
src/overview.html:246: </b>sharepoint.sts.realm=<b>urn:myserver:sharepoint or
https://yoursharepoint.example.com/_trust</b></pre>
see comment on line 77 about (not) boldfacing the "or"

Expand All Messages | Collapse All Messages