Issue 9747045: code review 9747045: cmd/vet: simplify format checker

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9747045: code review 9747045: cmd/vet: simplify format checker (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by r

Modified:
12 years, 5 months ago

Reviewers:
gri

CC:
gri, golang-dev

Visibility:
Public.

Description

cmd/vet: simplify format checker Simplify the code a bit, get it working after recent go/types changes, and handle "%*%" just in case. Preparation for handling argument indexing.

Patch Set 2 : diff -r 399682188b8b https://code.google.com/p/go.tools #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -52 lines)			Patch
M	cmd/vet/print.go	View	1	4 chunks	+38 lines, -33 lines	0 comments	Download
M	cmd/vet/testdata/print.go	View		2 chunks	+19 lines, -18 lines	0 comments	Download
M	cmd/vet/types.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

12 years, 5 months ago (2013-05-28 19:09:08 UTC) #1

gri

LGTM https://codereview.appspot.com/9747045/diff/1/cmd/vet/print.go File cmd/vet/print.go (right): https://codereview.appspot.com/9747045/diff/1/cmd/vet/print.go#newcode266 cmd/vet/print.go:266: // Linear scan is fast enough for a ...

12 years, 5 months ago (2013-05-28 19:31:47 UTC) #2

https://codereview.appspot.com/9747045/diff/1/cmd/vet/print.go File cmd/vet/print.go (right): https://codereview.appspot.com/9747045/diff/1/cmd/vet/print.go#newcode266 cmd/vet/print.go:266: // Linear scan is fast enough for a small ...

12 years, 5 months ago (2013-05-28 19:36:03 UTC) #3

12 years, 5 months ago (2013-05-28 19:37:36 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=b96d29f37d2e&repo=tools ***

cmd/vet: simplify format checker
Simplify the code a bit, get it working after recent go/types changes,
and handle "%*%" just in case. Preparation for handling argument indexing.

R=gri
CC=golang-dev
https://codereview.appspot.com/9747045

Expand All Messages | Collapse All Messages