Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 9742044: state/api: Split to multiple files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by dimitern
Modified:
11 years, 10 months ago
Reviewers:
mp+165687
Visibility:
Public.

Description

state/api: Split to multiple files To simplify maintenance and development, this CL splits the API client and server packages into multiple files. Tests are split as well. Nothing new introduced, just mechanical. I'm reproposing this, because the original CL (https://codereview.appspot.com/9746043) had issue. No changes here, just merged trunk. https://code.launchpad.net/~dimitern/juju-core/046-split-api-multiple-files-fixed/+merge/165687 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/api: Split to multiple files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3823 lines, -3608 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/api/apiclient.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M state/api/apierror.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M state/api/client.go View 3 chunks +0 lines, -578 lines 0 comments Download
A state/api/machine.go View 1 chunk +145 lines, -0 lines 0 comments Download
A state/api/state.go View 1 chunk +77 lines, -0 lines 0 comments Download
A state/api/unit.go View 1 chunk +48 lines, -0 lines 0 comments Download
A state/api/watcher.go View 1 chunk +339 lines, -0 lines 0 comments Download
A state/apiserver/admin.go View 1 chunk +20 lines, -0 lines 0 comments Download
M state/apiserver/api_test.go View 5 chunks +30 lines, -2069 lines 0 comments Download
M state/apiserver/apierror.go View 0 chunks +-1 lines, --1 lines 0 comments Download
D state/apiserver/apiserver.go View 1 chunk +0 lines, -965 lines 0 comments Download
D state/apiserver/apiserver.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A state/apiserver/client.go View 1 chunk +212 lines, -0 lines 0 comments Download
A state/apiserver/client_test.go View 1 chunk +442 lines, -0 lines 0 comments Download
A state/apiserver/errors_test.go View 1 chunk +88 lines, -0 lines 0 comments Download
A state/apiserver/login_test.go View 1 chunk +61 lines, -0 lines 0 comments Download
A state/apiserver/machine.go View 1 chunk +132 lines, -0 lines 0 comments Download
A state/apiserver/machine_test.go View 1 chunk +498 lines, -0 lines 0 comments Download
A state/apiserver/perm_test.go View 1 chunk +584 lines, -0 lines 0 comments Download
A state/apiserver/resource.go View 1 chunk +82 lines, -0 lines 0 comments Download
A state/apiserver/root.go View 1 chunk +274 lines, -0 lines 0 comments Download
A state/apiserver/scenario_test.go View 1 chunk +154 lines, -0 lines 0 comments Download
A state/apiserver/server_test.go View 1 chunk +125 lines, -0 lines 0 comments Download
A state/apiserver/state.go View 1 chunk +76 lines, -0 lines 0 comments Download
A state/apiserver/state_test.go View 1 chunk +144 lines, -0 lines 0 comments Download
A state/apiserver/unit.go View 1 chunk +41 lines, -0 lines 0 comments Download
A state/apiserver/unit_test.go View 1 chunk +49 lines, -0 lines 0 comments Download
A state/apiserver/user.go View 1 chunk +61 lines, -0 lines 0 comments Download
A state/apiserver/utils.go View 1 chunk +53 lines, -0 lines 0 comments Download
A state/apiserver/watcher.go View 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dimitern
Please take a look.
11 years, 10 months ago (2013-05-24 19:16:56 UTC) #1
dimitern
*** Submitted: state/api: Split to multiple files To simplify maintenance and development, this CL splits ...
11 years, 10 months ago (2013-05-24 19:21:41 UTC) #2
dimitern
11 years, 10 months ago (2013-05-24 19:23:00 UTC) #3
On 2013/05/24 19:16:56, dimitern wrote:
> Please take a look.

Already approved as trivial in https://codereview.appspot.com/9746043/
This is the same change, but with fixed apiserver.go
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b