Issue 9740052: code review 9740052: go.types/ssa: inline all calls to objKind().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9740052: code review 9740052: go.types/ssa: inline all calls to objKind(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by adonovan

Modified:
12 years, 5 months ago

Reviewers:
gri

CC:
gri, golang-dev

Visibility:
Public.

Description

go.types/ssa: inline all calls to objKind().

Patch Set 1 #

Patch Set 2 : diff -r ced2d1cfc206 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r ced2d1cfc206 https://code.google.com/p/go.tools #

Patch Set 4 : code review 9740052: go.types/ssa: inline all calls to objKind(). #

Patch Set 5 : diff -r ced2d1cfc206 https://code.google.com/p/go.tools #

Patch Set 6 : diff -r ced2d1cfc206 https://code.google.com/p/go.tools #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -28 lines)			Patch
M	ssa/builder.go	View	1 2 4	3 chunks	+4 lines, -7 lines	0 comments	Download
M	ssa/typeinfo.go	View	1 4	2 chunks	+6 lines, -4 lines	0 comments	Download
M	ssa/util.go	View	1 4	1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

12 years, 5 months ago (2013-05-30 15:16:03 UTC) #1

adonovan

12 years, 5 months ago (2013-05-30 16:13:44 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=dca0221c628a&repo=tools ***

go.types/ssa: inline all calls to objKind().

R=gri
CC=golang-dev
https://codereview.appspot.com/9740052

Expand All Messages | Collapse All Messages