Issue 9740048: Ensure the docs build before landing a branch.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9740048: Ensure the docs build before landing a branch.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by benji

Modified:
10 years, 11 months ago

Reviewers:
mp+166366, teknico

Visibility:
Public.

Description

Ensure the docs build before landing a branch. https://code.launchpad.net/~benji/juju-gui/check-test-docs/+merge/166366 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Ensure the docs build before landing a branch. #

Total comments: 2

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -2 lines)			Patch
M	Makefile	View	2 chunks	+2 lines, -2 lines	2 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	docs/index.rst	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

benji

I am self reviewing this. Plus, Nikola thought it was a good idea. I hope ...

10 years, 11 months ago (2013-05-29 19:29:31 UTC) #2

benji

*** Submitted: Ensure the docs build before landing a branch. R= CC= https://codereview.appspot.com/9740048

10 years, 11 months ago (2013-05-29 19:35:16 UTC) #3

teknico

LGTM, and you didn't look like someone needing to be placated. :-) (By the way, ...

10 years, 11 months ago (2013-05-29 19:43:41 UTC) #4

benji

10 years, 11 months ago (2013-05-29 20:17:57 UTC) #5

On Wed, May 29, 2013 at 2:43 PM,  <nicola.larosa@canonical.com> wrote:
> LGTM

Cool.

> (By the way, my name is Nicola, no "k", it's not like I'm Tesla or
> something. ;-) )

Darn, I knew I would do that one day.  IRC nicks and real names are
stored very close together in my head and the "k" in the one flipped
some bits in the "c" in the other.  I guess I need to upgrade to ECC.
-- 
Benji York

Expand All Messages | Collapse All Messages