Issue 9738045: code review 9738045: cmd/gc: remove unused bit vector comparison code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9738045: code review 9738045: cmd/gc: remove unused bit vector comparison code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by cshapiro1

Modified:
12 years, 1 month ago

Reviewers:
dave, iant

CC:
golang-dev, dave_cheney.net, iant

Visibility:
Public.

Description

cmd/gc: remove unused bit vector comparison code

Patch Set 1 #

Patch Set 2 : diff -r 02e5cb24c95a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 02e5cb24c95a https://code.google.com/p/go/ #

Patch Set 4 : diff -r 02e5cb24c95a https://code.google.com/p/go/ #

Patch Set 5 : diff -r 02e5cb24c95a https://code.google.com/p/go/ #

Patch Set 6 : diff -r 3f530b76de99 https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	src/cmd/gc/bv.c	View	1 2 3	1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

cshapiro1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2013-05-29 02:31:54 UTC) #1

dave_cheney.net

LGTM. Tested with 8g and 5g, I'm assuming you've already checked 6g.

12 years, 1 month ago (2013-05-29 06:43:23 UTC) #2

cshapiro1

12 years, 1 month ago (2013-05-29 18:46:20 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=65c110d95d91 ***

cmd/gc: remove unused bit vector comparison code

R=golang-dev, dave, iant
CC=golang-dev
https://codereview.appspot.com/9738045

Expand All Messages | Collapse All Messages