Issue 9731048: Avoid redundant image requests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9731048: Avoid redundant image requests.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by teknico

Modified:
10 years, 10 months ago

Reviewers:
mp+166090, bac, benji

Visibility:
Public.

Description

Avoid redundant image requests. When rendering services, avoid redundant image requests due to setting href attributes on SVG elements to values they already have. https://code.launchpad.net/~teknico/juju-gui/1182135-fix-xsv-lsc-asz-axs/+merge/166090 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Avoid redundant image requests. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -17 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	app/views/topology/service.js	View	1	3 chunks	+29 lines, -17 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

teknico

By the way, the branch name means "Fix excessive Landscape assets access." Sorry. :-)

10 years, 10 months ago (2013-05-28 16:19:50 UTC) #2

teknico

10 years, 10 months ago (2013-05-28 16:53:50 UTC) #5

*** Submitted:

Avoid redundant image requests.

When rendering services, avoid redundant image requests due to
setting href attributes on SVG elements to values they already
have.

R=benji, bac
CC=
https://codereview.appspot.com/9731048

Expand All Messages | Collapse All Messages