code review 9728044: runtime: allocate internal symbol table eagerly

runtime: allocate internal symbol table eagerly
we need it for GC anyway.

[dvyukov, 2013-05-27 07:49:58]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[khr, 2013-05-28 06:09:40]

LGTM

Get rid of the findfunc(0) call in pkg/runtime/cpuprof.c, it will no longer be
needed.

[dvyukov, 2013-05-28 07:03:06]

On Tue, May 28, 2013 at 10:09 AM, <khr@golang.org> wrote:

> LGTM
>
> Get rid of the findfunc(0) call in pkg/runtime/cpuprof.c, it will no
> longer be needed.
>


I think I need to remove the lazy initialization logic from findfunc()
entirely (mutex, etc). Call buildfuncs() during sched init, and then expect
that it's initialized in findfunc().
What do you think?

[dave_cheney.net, 2013-05-28 07:04:23]

> I think I need to remove the lazy initialization logic from findfunc()
> entirely (mutex, etc). Call buildfuncs() during sched init, and then expect
> that it's initialized in findfunc().
> What do you think?

SGTM.

[khr1, 2013-05-28 15:02:02]

Sounds good.


On Tue, May 28, 2013 at 12:04 AM, Dave Cheney <dave@cheney.net> wrote:

> > I think I need to remove the lazy initialization logic from findfunc()
> > entirely (mutex, etc). Call buildfuncs() during sched init, and then
> expect
> > that it's initialized in findfunc().
> > What do you think?
>
> SGTM.
>

[dvyukov, 2013-05-28 15:13:42]

> > > I think I need to remove the lazy initialization logic from findfunc()
> > > entirely (mutex, etc). Call buildfuncs() during sched init, and then
> > expect
> > > that it's initialized in findfunc().
> > > What do you think?


Done, PTAL.
much better now

[khr, 2013-05-28 15:52:17]

On 2013/05/28 15:13:42, dvyukov wrote:
> > > > I think I need to remove the lazy initialization logic from findfunc()
> > > > entirely (mutex, etc). Call buildfuncs() during sched init, and then
> > > expect
> > > > that it's initialized in findfunc().
> > > > What do you think?
> 
> 
> Done, PTAL.
> much better now

LGTM.

[dvyukov, 2013-05-28 17:10:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=c658ed1b4459 ***

runtime: allocate internal symbol table eagerly
we need it for GC anyway.

R=golang-dev, khr, dave, khr
CC=golang-dev
https://codereview.appspot.com/9728044