code review 97280043: cmd/go: simplify code, reduce allocations.

cmd/go: simplify code, reduce allocations.

This is a trivial change to make use of an existing `nl` byte slice
containing a single '\n' character. It's already declared and
used in another place in this file, so it might as well be used
in the other location instead of
a new slice literal. There should be no change in behavior,
aside from potentially less allocations.

This is my first CL, so I wanted to use a simple, hopefully non-controversial,
minor improvement to get more comfortable with golang contribution process.

[shurcooL, 2014-05-11 00:37:23]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-05-11 00:40:15]

LGTM



On Sat, May 10, 2014 at 5:37 PM, <shurcooL@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/go: simplify code, reduce allocations.
>
> This is a trivial change to make use of an existing `nl` byte slice
> containing a single '\n' character. It's already declared and
> used in another place in this file, so it might as well be used
> in the other location instead of
> a new slice literal. There should be no change in behavior,
> aside from potentially less allocations.
>
> This is my first CL, so I wanted to use a simple, hopefully
> non-controversial,
> minor improvement to get more comfortable with golang contribution
> process.
>
> Please review this at https://codereview.appspot.com/97280043/
>
> Affected files (+1, -1 lines):
>   M src/cmd/go/list.go
>
>
> Index: src/cmd/go/list.go
> ===================================================================
> --- a/src/cmd/go/list.go
> +++ b/src/cmd/go/list.go
> @@ -161,7 +161,7 @@
>                                 fatalf("%s", err)
>                         }
>                         if out.NeedNL() {
> -                               out.Write([]byte{'\n'})
> +                               out.Write(nl)
>                         }
>                 }
>         }
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[bradfitz, 2014-05-11 01:07:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=299229ac4300 ***

cmd/go: simplify code, reduce allocations.

This is a trivial change to make use of an existing `nl` byte slice
containing a single '\n' character. It's already declared and
used in another place in this file, so it might as well be used
in the other location instead of
a new slice literal. There should be no change in behavior,
aside from potentially less allocations.

This is my first CL, so I wanted to use a simple, hopefully non-controversial,
minor improvement to get more comfortable with golang contribution process.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/97280043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[bradfitz, 2014-05-11 01:08:41]

I approved and submitted this, but it really is freeze time. Please hold on
future contributions, however minor, until Go 1.3 is out.  I figured this
will get us a bit more builder testing at least.



On Sat, May 10, 2014 at 6:07 PM, <bradfitz@golang.org> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=299229ac4300 ***
>
>
> cmd/go: simplify code, reduce allocations.
>
> This is a trivial change to make use of an existing `nl` byte slice
> containing a single '\n' character. It's already declared and
> used in another place in this file, so it might as well be used
> in the other location instead of
> a new slice literal. There should be no change in behavior,
> aside from potentially less allocations.
>
> This is my first CL, so I wanted to use a simple, hopefully
> non-controversial,
> minor improvement to get more comfortable with golang contribution
> process.
>
> LGTM=bradfitz
> R=golang-codereviews, bradfitz
> CC=golang-codereviews
> https://codereview.appspot.com/97280043
>
> Committer: Brad Fitzpatrick <bradfitz@golang.org>
>
>
> https://codereview.appspot.com/97280043/
>