Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(315)

Issue 9727045: code review 9727045: go.net/ipv4: Expose SpecDst in ControlMessage and set i...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by anacrolix
Modified:
7 years, 8 months ago
Reviewers:
CC:
golang-codereviews, mikio, bradfitz
Visibility:
Public.

Description

go.net/ipv4: Expose SpecDst in ControlMessage and set it from ipi_spec_dst. See man ip(7). Fixes issue 5576.

Patch Set 1 #

Patch Set 2 : diff -r 05cd37416659 https://code.google.com/p/go.net #

Patch Set 3 : code review 9727045: go.net/ipv4: Expose SpecDst in ControlMessage and set i... #

Patch Set 4 : code review 9727045: go.net/ipv4: Expose SpecDst in ControlMessage and set i... #

Patch Set 5 : code review 9727045: go.net/ipv4: Expose SpecDst in ControlMessage and set i... #

Patch Set 6 : diff -r 3591c18acabc https://code.google.com/p/go.net #

Patch Set 7 : diff -r 3591c18acabc https://code.google.com/p/go.net #

Total comments: 1

Patch Set 8 : diff -r 89dbba2db2d4 https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ipv4/control.go View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M ipv4/control_linux.go View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11
anacrolix
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
9 years ago (2013-08-09 06:15:48 UTC) #1
mikio
In the CL desc "See man ip(7)" doesn't work except on Linux. https://codereview.appspot.com/9727045/diff/11003/ipv4/control.go File ipv4/control.go ...
9 years ago (2013-08-17 07:49:56 UTC) #2
mikio
and "Fixes issue 5576."
9 years ago (2013-08-17 07:54:55 UTC) #3
anacrolix
On 2013/08/17 07:49:56, mikio wrote: > In the CL desc "See man ip(7)" doesn't work ...
9 years ago (2013-08-19 02:15:39 UTC) #4
gobot
Replacing golang-dev with golang-codereviews.
8 years, 8 months ago (2013-12-20 16:11:03 UTC) #5
gobot
Replacing golang-dev with golang-codereviews.
8 years, 8 months ago (2013-12-20 16:12:03 UTC) #6
gobot
Replacing golang-dev with golang-codereviews.
8 years, 8 months ago (2013-12-20 16:13:20 UTC) #7
gobot
Replacing golang-dev with golang-codereviews.
8 years, 8 months ago (2013-12-20 16:19:36 UTC) #8
anacrolix
Hello golang-codereviews@googlegroups.com, mikioh.mikioh@gmail.com, nigeltao (cc: bradfitz, golang-codereviews@googlegroups.com), Please take another look.
8 years, 5 months ago (2014-02-25 03:22:12 UTC) #9
nigeltao
I'm not familiar with go.net/ipv4, so I'm removing myself from the reviewers list.
8 years, 5 months ago (2014-02-25 05:14:22 UTC) #10
gobot
7 years, 8 months ago (2014-12-19 05:19:23 UTC) #11
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/9727045 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b