Code review - Issue 9727045: code review 9727045: go.net/ipv4: Expose SpecDst in ControlMessage and set i...https://codereview.appspot.com/2014-12-19T05:19:23+00:00rietveld
Message from unknown
2013-05-28T12:15:43+00:00anacrolixurn:md5:e8f019e6e773dbf400a3fe9fa1273e85
Message from unknown
2013-05-28T12:15:51+00:00anacrolixurn:md5:997f929dff410619e5a422e7a3d934a7
Message from unknown
2013-08-09T06:01:54+00:00anacrolixurn:md5:4a742eb177e4d0d82b43c30663ad5b55
Message from unknown
2013-08-09T06:13:41+00:00anacrolixurn:md5:8b4f2933eeb10ef4f8ce1e407d342c1a
Message from unknown
2013-08-09T06:14:37+00:00anacrolixurn:md5:e9fd6140ea22e3b893b84452275f9a94
Message from unknown
2013-08-09T06:15:30+00:00anacrolixurn:md5:d362b2b2d9e0e76bc6e275d2ca3d80d6
Message from unknown
2013-08-09T06:15:42+00:00anacrolixurn:md5:12b440f4bea498b3180f7dc88b1dd444
Message from anacrolix@gmail.com
2013-08-09T06:15:48+00:00anacrolixurn:md5:c6a3e3fce2cf82d109e72b755310102b
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/go.net
Message from mikioh.mikioh@gmail.com
2013-08-17T07:49:56+00:00mikiourn:md5:c3765dd4cd1a96465ff9476d6431f136
In the CL desc "See man ip(7)" doesn't work except on Linux.
https://codereview.appspot.com/9727045/diff/11003/ipv4/control.go
File ipv4/control.go (right):
https://codereview.appspot.com/9727045/diff/11003/ipv4/control.go#newcode43
ipv4/control.go:43: SpecDst net.IP // local address of packet
I still don't understand the reason why SpecDst? Why not Routing, Hop or whatever related to routing stuff? Also "local address of packet" makes us confuse. Perhaps test might help up to understand, so please add test cases for both receiving and specifying.
Message from mikioh.mikioh@gmail.com
2013-08-17T07:54:55+00:00mikiourn:md5:91ed5340a4b24f695a49d57055f4276a
and "Fixes issue 5576."
Message from anacrolix@gmail.com
2013-08-19T02:15:39+00:00anacrolixurn:md5:ea1d2fdcbd08367882cf63d51b004630
On 2013/08/17 07:49:56, mikio wrote:
> In the CL desc "See man ip(7)" doesn't work except on Linux.
>
> https://codereview.appspot.com/9727045/diff/11003/ipv4/control.go
> File ipv4/control.go (right):
>
> https://codereview.appspot.com/9727045/diff/11003/ipv4/control.go#newcode43
> ipv4/control.go:43: SpecDst net.IP // local address of packet
> I still don't understand the reason why SpecDst? Why not Routing, Hop or
> whatever related to routing stuff? Also "local address of packet" makes us
> confuse. Perhaps test might help up to understand, so please add test cases for
> both receiving and specifying.
Because there's no reason to give it another name. The field already has multiple uses, I can't claim to know better than the Linux kernel developer what this field represents. To rename it is to potentially mislead.
Message from gobot@golang.org
2013-12-20T16:11:03+00:00goboturn:md5:81864ec1ddd612d4addaa1a6b47275b7
Replacing golang-dev with golang-codereviews.
Message from gobot@golang.org
2013-12-20T16:12:03+00:00goboturn:md5:90e693814ce757ef55c4268e93d38f4d
Replacing golang-dev with golang-codereviews.
Message from gobot@golang.org
2013-12-20T16:13:20+00:00goboturn:md5:da9cd4f51ffc71214352a6c201ee59ab
Replacing golang-dev with golang-codereviews.
Message from gobot@golang.org
2013-12-20T16:19:36+00:00goboturn:md5:b6ad9df193a3244cd5fbc23ddfe1a05e
Replacing golang-dev with golang-codereviews.
Message from unknown
2014-02-25T03:22:04+00:00anacrolixurn:md5:841237530c3e364aec45ce9135c72c97
Message from anacrolix@gmail.com
2014-02-25T03:22:12+00:00anacrolixurn:md5:2a27e1ea9b08171c4df2cb66d90f7b38
Hello golang-codereviews@googlegroups.com, mikioh.mikioh@gmail.com, nigeltao (cc: bradfitz, golang-codereviews@googlegroups.com),
Please take another look.
Message from nigeltao@golang.org
2014-02-25T05:14:22+00:00nigeltaourn:md5:fd76b692eadffb74ec316bbfbe7ceda3
I'm not familiar with go.net/ipv4, so I'm removing myself from the reviewers list.
Message from gobot@golang.org
2014-12-19T05:19:23+00:00goboturn:md5:ded217c8d8e69cae9091c54ae777bde6
R=close
To the author of this CL:
The Go project has moved to Gerrit Code Review.
If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.
If there has been discussion on this CL, please give a link to it
(golang.org/cl/9727045 is best) in the description in your
new CL.
Thanks very much.