Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(178)

Issue 97240043: testing: use juju-mongodb when appropriate

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by jameinel
Modified:
10 years ago
Reviewers:
mp+218928, fwereade
Visibility:
Public.

Description

testing: use juju-mongodb when appropriate This should address parts of both bug #1301353 and bug #1304770. Instead of requiring a 'mongod' to be in PATH, we'll also search for /usr/lib/juju/bin/mongod which is from the juju-mongodb package. For core tests, we prefer the juju-mongodb version (since jujud itself will prefer it), and for store tests we prefer 'mongod' on PATH since it will have the v8 engine and allow us to run all the tests. This also auto-detects when noTestMongoJS should be set because it is using the /usr/lib/juju/bin/mongod executable. Note that this autodetection *fails* for people who have been hacking around support by symlinking /usr/lib/juju/bin/mongod back into their PATH. So I didn't remove the ENV variable, but it should no longer be necessary. I'm targetting 1.18 because with this patch I think Juju CI will have to do less hackery to have the test suite JustWork for them. https://code.launchpad.net/~jameinel/juju-core/1.18-trusty-mongodb-1301353/+merge/218928 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : testing: use juju-mongodb when appropriate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -7 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M store/mgo_test.go View 1 chunk +21 lines, -4 lines 0 comments Download
M testing/mgo.go View 1 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 3
jameinel
Please take a look.
10 years ago (2014-05-09 07:51:40 UTC) #1
fwereade
LGTM, just trivials/suggestions https://codereview.appspot.com/97240043/diff/1/testing/mgo.go File testing/mgo.go (right): https://codereview.appspot.com/97240043/diff/1/testing/mgo.go#newcode148 testing/mgo.go:148: // is available, it will be ...
10 years ago (2014-05-09 08:01:25 UTC) #2
jameinel
10 years ago (2014-05-09 08:08:57 UTC) #3
Please take a look.

https://codereview.appspot.com/97240043/diff/1/testing/mgo.go
File testing/mgo.go (right):

https://codereview.appspot.com/97240043/diff/1/testing/mgo.go#newcode148
testing/mgo.go:148: // is available, it will be use preferentially
On 2014/05/09 08:01:25, fwereade wrote:
> s/use/used/

Done.

https://codereview.appspot.com/97240043/diff/1/testing/mgo.go#newcode160
testing/mgo.go:160: }
On 2014/05/09 08:01:25, fwereade wrote:
> maybe log mongopath here and not above?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b