Issue 9721043: state/api: Implement provisioner API calls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9721043: state/api: Implement provisioner API calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by dimitern

Modified:
10 years, 11 months ago

Reviewers:
mp+165566

Visibility:
Public.

Description

state/api: Implement provisioner API calls This adds more API objects and calls, as needed by the provisioner: * LifecycleWatcher * EnvironConfigWatcher * All client-side watchers were refactored to reduce code duplication and make adding new ones and also maintaining them much easier. * State object at top-level (like Machine, Unit, Client). * State.AllMachines * State.WatchMachines - using LifecycleWatcher * State.WatchEnvironConfig - using EnvironConfigWatcher * Machine.Series * Machine.Remove * Machine.Status * Machine.SetProvisioned * Machine.SetMongoPassword * Machine.Constraints Calling Machine.EnsureDead now allowed for both owning agents and the environment manager. Most restrictive permission checks implemented for Machine.Constraints, .Status, .SetProvisioned and .SetMongoPassword (environment manager only allowed). For some of them we might relax the restriction in the future, as needed, so the owning agent can also call them. https://code.launchpad.net/~dimitern/juju-core/041-provisioner-api-calls/+merge/165566 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1086 lines, -133 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/apiclient.go	View	8 chunks	+309 lines, -47 lines	0 comments	Download
M	state/api/params/params.go	View	4 chunks	+51 lines, -0 lines	0 comments	Download
M	state/apiserver/api_test.go	View	29 chunks	+483 lines, -76 lines	0 comments	Download
M	state/apiserver/apiserver.go	View	9 chunks	+241 lines, -10 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dimitern

10 years, 11 months ago (2013-05-24 10:28:40 UTC) #2

On 2013/05/24 10:15:52, dimitern wrote:
> Please take a look.

I didn't realize the diff is so big. I'll split it in several CLs for easier
reviewing. Please disregard this one.

Expand All Messages | Collapse All Messages