Issue 97160044: Another attempt to fix tools tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 97160044: Another attempt to fix tools tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by wallyworld

Modified:
9 years, 11 months ago

Reviewers:
axw, mp+219273

Visibility:
Public.

Description

Another attempt to fix tools tests A first attempt to ensure the required fake tools were uploaded for tests failed. This rework uses a cleaner approach - the ToolsLtsSeries slice from environs/bootstrap is used to determine what tools to upload. https://code.launchpad.net/~wallyworld/juju-core/fix-fake-tools-trusty-2/+merge/219273 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -9 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/bootstrap/synctools.go	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	environs/testing/tools.go	View	2 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw

9 years, 11 months ago (2014-05-13 01:11:15 UTC) #2

On 2014/05/12 23:25:37, wallyworld wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages