Issue 97120046: code review 97120046: cmd/go: link SWIG objects directly rather than using a ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 97120046: code review 97120046: cmd/go: link SWIG objects directly rather than using a ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by iant

Modified:
10 years, 11 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

cmd/go: link SWIG objects directly rather than using a shared library This change requires using SWIG version 3.0 or later. Earlier versions of SWIG do not generate the pragmas required to use the external linker. Fixes issue 7155. Fixes issue 7156.

Patch Set 1 #

Patch Set 2 : diff -r a6cb2adc55eb https://code.google.com/p/go #

Patch Set 3 : diff -r e436f20a5029 https://code.google.com/p/go #

Patch Set 4 : diff -r 06d8b8553a44 https://code.google.com/p/go #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -112 lines)			Patch
M	doc/go1.3.html	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/cmd/go/build.go	View	1 2 3	18 chunks	+26 lines, -79 lines	0 comments	Download
M	src/cmd/go/clean.go	View	1 2	1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/cmd/go/doc.go	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/go/pkg.go	View		1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 11 months ago (2014-05-07 20:18:11 UTC) #1

iant

On Fri, May 9, 2014 at 12:53 PM, Russ Cox <rsc@golang.org> wrote: > Fixes issue ...

10 years, 11 months ago (2014-05-09 19:58:55 UTC) #4

iant

10 years, 11 months ago (2014-05-12 19:44:21 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=5d4d29c225e6 ***

cmd/go: link SWIG objects directly rather than using a shared library

This change requires using SWIG version 3.0 or later.  Earlier
versions of SWIG do not generate the pragmas required to use
the external linker.

Fixes issue 7155.
Fixes issue 7156.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/97120046

Expand All Messages | Collapse All Messages