Rename genxml to bundle, and copy in required jars.

[woodie, 2009-07-24 20:32:18]

Do I need to get my changes in, to avoid a merge?

[do_not_use, 2009-07-24 22:56:56]

Ok, I've merged in dev_appserver.rb

[woodie, 2009-07-25 00:49:17]

this is great!

http://codereview.appspot.com/97113/diff/1005/7
File lib/appengine-tools/appcfg.rb (right):

http://codereview.appspot.com/97113/diff/1005/7#newcode77
Line 77: if command && ! NO_XML_COMMANDS.include?(command)
we could also put some friendly feedback here
like he have in the dev_appserver

http://codereview.appspot.com/97113/diff/1005/11
File lib/appengine-tools/bundler.rb (right):

http://codereview.appspot.com/97113/diff/1005/11#newcode66
Line 66: class AppBundler
this seems brittle. I'll will write something
to verify that jars and return version info...

http://codereview.appspot.com/97113/diff/1005/11#newcode105
Line 105: # TODO auto generate a config.ru
that sounds fantastic, but when/where does that happen?

http://codereview.appspot.com/97113/diff/1005/11#newcode108
Line 108: puts 'Error: you either need a #{app.config_ru} or '
these need to be double quotes

http://codereview.appspot.com/97113/diff/1005/11#newcode109
Line 109: puts '      #{app.aeweb_xml}.'
...double quotes

http://codereview.appspot.com/97113/diff/1005/11#newcode113
Line 113: puts 'Error: you need to create #{app.config_ru}.'
..double quotes

http://codereview.appspot.com/97113/diff/1005/11#newcode134
Line 134: # TODO cache this somewhere
Small and easy to download, that seems fine.
It you just stick it in /tmp (Java should define one),
that will save time during a hacking session.

http://codereview.appspot.com/97113/diff/1005/11#newcode150
Line 150: # TODO if there's more than 1 we need to check the api version.
Having this part of the SDK makes this difficult.
It would be nice to have a gem for this as well,
and the appengin-spis depend on, or just included.

http://codereview.appspot.com/97113/diff/1005/9
File lib/appengine-tools/dev_appserver.rb (right):

http://codereview.appspot.com/97113/diff/1005/9#newcode30
Line 30: AppEngine::Admin.bundle args[-1]
I assume bundler can spit out more information
after scanning the jars, and the associated 
messages when you should upgrade

[do_not_use, 2009-07-25 01:05:14]

http://codereview.appspot.com/97113/diff/1005/7
File lib/appengine-tools/appcfg.rb (right):

http://codereview.appspot.com/97113/diff/1005/7#newcode77
Line 77: if command && ! NO_XML_COMMANDS.include?(command)
What do you think would be useful? As long as the check's run quickly I don't
want to be too verbose.

On 2009/07/25 00:49:17, woodie wrote:
> we could also put some friendly feedback here
> like he have in the dev_appserver

http://codereview.appspot.com/97113/diff/1005/11
File lib/appengine-tools/bundler.rb (right):

http://codereview.appspot.com/97113/diff/1005/11#newcode105
Line 105: # TODO auto generate a config.ru
On 2009/07/25 00:49:17, woodie wrote:
> that sounds fantastic, but when/where does that happen?

below, instead of just printing an error message. I've moved the TODO to the
correct place.

http://codereview.appspot.com/97113/diff/1005/11#newcode108
Line 108: puts 'Error: you either need a #{app.config_ru} or '
On 2009/07/25 00:49:17, woodie wrote:
> these need to be double quotes

Done.

http://codereview.appspot.com/97113/diff/1005/11#newcode109
Line 109: puts '      #{app.aeweb_xml}.'
On 2009/07/25 00:49:17, woodie wrote:
> ...double quotes

Done.

http://codereview.appspot.com/97113/diff/1005/11#newcode113
Line 113: puts 'Error: you need to create #{app.config_ru}.'
On 2009/07/25 00:49:17, woodie wrote:
> ..double quotes

Done.

http://codereview.appspot.com/97113/diff/1005/11#newcode150
Line 150: # TODO if there's more than 1 we need to check the api version.
On 2009/07/25 00:49:17, woodie wrote:
> Having this part of the SDK makes this difficult.
> It would be nice to have a gem for this as well,
> and the appengin-spis depend on, or just included.

The sdk treats this jar specially. We can't modify it if we want things to work
right.