environs/cloudinit: write machine config earlier

environs/cloudinit: write machine config earlier

TLDR: this makes it easier to implement the API connection
logic.

For security reasons we get the agent to change its password from the
one that's passed in cloudinit. Currently that's done when connecting
to the mongo state.

The plan is to make that be done when connecting to the API, which
should work fine *apart* from when we're starting the bootstrap node,
which does not have an API to connect to.

Rather than duplicating the password changing logic for state and API
connections (and suffering races between the two things both trying to
change the password, or from the API connection changing the password
while a state connection is already active), we can alter bootstrap-state
so it changes the machine config on the bootstrap node so that its
machine agent won't *need* to change the password.

To do that, bootstrap-state needs access to the machine agent
configuration file, which is what this merge proposal implements.

https://code.launchpad.net/~rogpeppe/juju-core/308-jujud-bootstrap-state-change-password/+merge/165559

(do not edit description out of merge proposal)

[rog, 2013-05-24 09:47:06]

Please take a look.

[dimitern, 2013-05-24 09:52:40]

LGTM

[mue, 2013-05-24 10:10:47]

LGTM

[rog, 2013-05-24 11:17:57]

*** Submitted:

environs/cloudinit: write machine config earlier

TLDR: this makes it easier to implement the API connection
logic.

For security reasons we get the agent to change its password from the
one that's passed in cloudinit. Currently that's done when connecting
to the mongo state.

The plan is to make that be done when connecting to the API, which
should work fine *apart* from when we're starting the bootstrap node,
which does not have an API to connect to.

Rather than duplicating the password changing logic for state and API
connections (and suffering races between the two things both trying to
change the password, or from the API connection changing the password
while a state connection is already active), we can alter bootstrap-state
so it changes the machine config on the bootstrap node so that its
machine agent won't *need* to change the password.

To do that, bootstrap-state needs access to the machine agent
configuration file, which is what this merge proposal implements.

R=dimitern, TheWorkingMue
CC=
https://codereview.appspot.com/9710044