Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4093)

Issue 97100045: state: reduce default dial timeout to 30s

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by axw
Modified:
9 years, 11 months ago
Reviewers:
mp+218568
Visibility:
Public.

Description

state: reduce default dial timeout to 30s Previously we could have been dialling state connections across the Internet, since the CLI would connect to Mongo directly. Now, with the CLI going to API only, we can safely reduce the timeout. It is possible that the timeout will be exceeded if the peers in an HA setup are not all ready. In this case the dial operation will fail and the caller (state server agent) will restart. This change will reduce the time to failure in tests, and allow us to capture some information about the failed test without exceeding the Go test timeout. https://code.launchpad.net/~axwalk/juju-core/state-dialtimeout/+merge/218568 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/open.go View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2
axw
Please take a look.
9 years, 11 months ago (2014-05-07 08:25:25 UTC) #1
axw
9 years, 11 months ago (2014-05-07 09:47:52 UTC) #2
On 2014/05/07 08:25:25, axw wrote:
> Please take a look.

jam has LGTM'd on the MP
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b