state/api: Rest of provisioner API calls

state/api: Rest of provisioner API calls

New calls added to the API needed by the provisioner:
* Machine.Remove
* Machine.Series
* Machine.Constraints
* Machine.SetProvisioned
* Machine.Status
* State.AllMachines

All of the above are agent-only APIs, and except for
Series, currently can be called only by the environment
manager.

SetMongoPassword is not needed anymore for the agents,
because it's handled by the API server when calling
SetPassword (see https://codereview.appspot.com/9723043).

Some cleanup was performed driving by the code,
like improved comments and removed redundant ones.

https://code.launchpad.net/~dimitern/juju-core/044-machine-api-provisioner/+merge/165635

(do not edit description out of merge proposal)

[dimitern, 2013-05-24 14:43:52]

Please take a look.

[dimitern, 2013-05-24 14:48:02]

Please take a look.

[dimitern, 2013-05-24 14:50:40]

Please take a look.

[mue, 2013-05-24 14:58:09]

LGTM

[rog, 2013-05-24 15:18:04]

LGTM with a few minor comments. nice.

https://codereview.appspot.com/9708044/diff/1006/state/api/apiclient.go
File state/api/apiclient.go (right):

https://codereview.appspot.com/9708044/diff/1006/state/api/apiclient.go#newco...
state/api/apiclient.go:398: func (m *Machine) SetMongoPassword(password string)
error {
i don't think we should have this.
the recent CL i submitted (https://codereview.appspot.com/9723043) allows this
in a different way.

https://codereview.appspot.com/9708044/diff/1006/state/apiserver/api_test.go
File state/apiserver/api_test.go (right):

https://codereview.appspot.com/9708044/diff/1006/state/apiserver/api_test.go#...
state/apiserver/api_test.go:89: allow: []string{"machine-0"},
this can go

https://codereview.appspot.com/9708044/diff/1006/state/apiserver/api_test.go#...
state/apiserver/api_test.go:352: c.Check(err.Error(), Matches, `cannot set
instance id of machine "1": already set`)
c.Check(err, ErrorMatches, ...)

https://codereview.appspot.com/9708044/diff/1006/state/apiserver/api_test.go#...
state/apiserver/api_test.go:639: 
d

https://codereview.appspot.com/9708044/diff/1006/state/apiserver/api_test.go#...
state/apiserver/api_test.go:1170: // TODO (dimitern): If we change the
permissions for
that's not really a TODO - more of a note.
i'd prefer TODOs for things we actually need to do.

[dimitern, 2013-05-24 15:36:49]

*** Submitted:

state/api: Rest of provisioner API calls

New calls added to the API needed by the provisioner:
* Machine.Remove
* Machine.Series
* Machine.Constraints
* Machine.SetProvisioned
* Machine.Status
* State.AllMachines

All of the above are agent-only APIs, and except for
Series, currently can be called only by the environment
manager.

SetMongoPassword is not needed anymore for the agents,
because it's handled by the API server when calling
SetPassword (see https://codereview.appspot.com/9723043).

Some cleanup was performed driving by the code,
like improved comments and removed redundant ones.

R=mue, rog
CC=
https://codereview.appspot.com/9708044

https://codereview.appspot.com/9708044/diff/1006/state/api/apiclient.go
File state/api/apiclient.go (right):

https://codereview.appspot.com/9708044/diff/1006/state/api/apiclient.go#newco...
state/api/apiclient.go:398: func (m *Machine) SetMongoPassword(password string)
error {
On 2013/05/24 15:18:04, rog wrote:
> i don't think we should have this.
> the recent CL i submitted (https://codereview.appspot.com/9723043) allows this
> in a different way.

Removed.

https://codereview.appspot.com/9708044/diff/1006/state/apiserver/api_test.go
File state/apiserver/api_test.go (right):

https://codereview.appspot.com/9708044/diff/1006/state/apiserver/api_test.go#...
state/apiserver/api_test.go:89: allow: []string{"machine-0"},
On 2013/05/24 15:18:04, rog wrote:
> this can go

Done.

https://codereview.appspot.com/9708044/diff/1006/state/apiserver/api_test.go#...
state/apiserver/api_test.go:352: c.Check(err.Error(), Matches, `cannot set
instance id of machine "1": already set`)
On 2013/05/24 15:18:04, rog wrote:
> c.Check(err, ErrorMatches, ...)

Done.

https://codereview.appspot.com/9708044/diff/1006/state/apiserver/api_test.go#...
state/apiserver/api_test.go:639: 
On 2013/05/24 15:18:04, rog wrote:
> d

Done.

https://codereview.appspot.com/9708044/diff/1006/state/apiserver/api_test.go#...
state/apiserver/api_test.go:1170: // TODO (dimitern): If we change the
permissions for
On 2013/05/24 15:18:04, rog wrote:
> that's not really a TODO - more of a note.
> i'd prefer TODOs for things we actually need to do.

changed to NOTE.