Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2027)

Issue 9704043: Add docs and clean up

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by gary.poster
Modified:
10 years, 11 months ago
Reviewers:
bac, mp+165497, jeff.pihach
Visibility:
Public.

Description

Add docs and clean up Add docs to a few functions. Remove some functions that were not used. Fix generating docs, and a few typos here and there. https://code.launchpad.net/~gary/juju-gui/doc-cleanup/+merge/165497 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add docs and clean up #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -302 lines) Patch
M CHANGES.yaml View 1 chunk +3 lines, -3 lines 0 comments Download
M Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/utils.js View 1 9 chunks +61 lines, -92 lines 1 comment Download
M undocumented View 1 chunk +199 lines, -205 lines 0 comments Download

Messages

Total messages: 5
gary.poster
Please take a look.
10 years, 11 months ago (2013-05-23 22:27:15 UTC) #1
jeff.pihach
LGTM Thanks for the cleanup! https://codereview.appspot.com/9704043/diff/1/app/views/utils.js File app/views/utils.js (right): https://codereview.appspot.com/9704043/diff/1/app/views/utils.js#newcode36 app/views/utils.js:36: @class utils These comment ...
10 years, 11 months ago (2013-05-23 22:35:28 UTC) #2
gary.poster
Thank you for the review! I think your question is a great one about the ...
10 years, 11 months ago (2013-05-23 23:39:02 UTC) #3
gary.poster
*** Submitted: Add docs and clean up Add docs to a few functions. Remove some ...
10 years, 11 months ago (2013-05-23 23:47:51 UTC) #4
bac
10 years, 11 months ago (2013-05-24 13:28:49 UTC) #5
doh, too late, didn't see you'd submitted already.  still, a lovely branch.

https://codereview.appspot.com/9704043/diff/6001/app/views/utils.js
File app/views/utils.js (left):

https://codereview.appspot.com/9704043/diff/6001/app/views/utils.js#oldcode308
app/views/utils.js:308: 
Gross, we had it in there twice just for good measure?  Good eye.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b