Issue 9703044: code review 9703044: go.tools/ssa: print identifer location if not found in ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9703044: code review 9703044: go.tools/ssa: print identifer location if not found in ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by gri

Modified:
13 years, 1 month ago

Reviewers:
r

CC:
adonovan, r, golang-dev

Visibility:
Public.

Description

go.tools/ssa: print identifer location if not found in TypeInfo

Patch Set 1 #

Patch Set 2 : diff -r f51aa0293205 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r f51aa0293205 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 7730491448d2 https://code.google.com/p/go.tools #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	ssa/builder.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	ssa/typeinfo.go	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

13 years, 1 month ago (2013-05-25 16:19:41 UTC) #1

gri

13 years, 1 month ago (2013-05-25 17:04:57 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=a7fc50329a08&repo=tools ***

go.tools/ssa: print identifer location if not found in TypeInfo

R=adonovan, r
CC=golang-dev
https://codereview.appspot.com/9703044

Expand All Messages | Collapse All Messages