Issue 96960044: code review 96960044: syscall: add missing TIOCGSID for openbsd/386

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96960044: code review 96960044: syscall: add missing TIOCGSID for openbsd/386 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by mikio

Modified:
11 years ago

Reviewers:
iant

CC:
jsing, rsc, iant, golang-codereviews

Visibility:
Public.

Description

syscall: add missing TIOCGSID for openbsd/386 The previous syscall constants regeneration on openbsd was conducted with OpenBSD current 3 months ago and it missed updating openbsd/386. This CL adds TIOCGSID for fixing the inconsistency between opensbd/amd64 and openbsd/386. Update issue 7049

Patch Set 1 : diff -r 2e591e82a8c8 https://code.google.com/p/go #

Patch Set 2 : diff -r dcf1fdbf4686 https://code.google.com/p/go #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/pkg/syscall/zerrors_openbsd_386.go	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello jsing@google.com, rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years ago (2014-05-03 00:29:31 UTC) #1

mikio

11 years ago (2014-05-05 22:22:17 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ea90f25d321f ***

syscall: add missing TIOCGSID for openbsd/386

The previous syscall constants regeneration on openbsd was conducted
with OpenBSD current 3 months ago and it missed updating openbsd/386.
This CL adds TIOCGSID for fixing the inconsistency between opensbd/amd64
and openbsd/386.

Update issue 7049

LGTM=iant
R=jsing, rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/96960044

Expand All Messages | Collapse All Messages