Issue 96850044: code review 96850044: go.tools/imports: If func main() exists, add package de...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96850044: code review 96850044: go.tools/imports: If func main() exists, add package de...

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by smwca

Modified:
10 years ago

Reviewers:
crawshaw1, bradfitz

CC:
bradfitz, crawshaw1, golang-codereviews

Visibility:
Public.

Description

go.tools/imports: If func main() exists, add package declaration Assuming: 1) package declaration does not exist 2) the Fragment option is set 3) a main function exists We will assume it is a main package and add the declaration. This change also sets the Fragment option in goimports.

Patch Set 1 #

Patch Set 2 : diff -r f8e4c8ae7a71 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r f8e4c8ae7a71 https://code.google.com/p/go.tools #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -3 lines)			Patch
M	cmd/goimports/goimports.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	imports/fix_test.go	View	1	2 chunks	+27 lines, -1 line	0 comments	Download
M	imports/imports.go	View	1	2 chunks	+32 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

smwca

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years ago (2014-04-27 02:04:49 UTC) #1

bradfitz

10 years ago (2014-04-28 21:15:37 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=e4cb80ed8405&repo=tools ***

imports, cmd/goimports: add missing package main if func main exists

Assuming:
        1) package declaration does not exist
        2) the Fragment option is set
        3) a main function exists

We will assume it is a main package and add the declaration.

This change also sets the Fragment option in goimports.

LGTM=crawshaw, bradfitz
R=bradfitz, crawshaw
CC=golang-codereviews
https://codereview.appspot.com/96850044

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages