Issue 9681045: worker/*: implement worker.Worker

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9681045: worker/*: implement worker.Worker

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by rog

Modified:
10 years, 11 months ago

Reviewers:
mue, dimitern, mp+165541

Visibility:
Public.

Description

worker/*: implement worker.Worker They all need a Kill method to be used with worker.Runner. https://code.launchpad.net/~rogpeppe/juju-core/307-workers-become-workers/+merge/165541 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : worker/*: implement worker.Worker #

Patch Set 3 : worker/*: implement worker.Worker #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -6 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/upgrade.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	cmd/jujud/upgrade_test.go	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	worker/deployer/deployer.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	worker/deployer/deployer_test.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/firewaller/firewaller.go	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	worker/firewaller/firewaller_test.go	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	worker/machiner/machiner.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	worker/machiner/machiner_test.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/provisioner/provisioner.go	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	worker/provisioner/provisioner_test.go	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	worker/uniter/uniter.go	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	worker/uniter/uniter_test.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

10 years, 11 months ago (2013-05-24 09:44:34 UTC) #4

*** Submitted:

worker/*: implement worker.Worker

They all need a Kill method to be used with worker.Runner.

R=dimitern, TheWorkingMue
CC=
https://codereview.appspot.com/9681045

Expand All Messages | Collapse All Messages