Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(797)

Issue 9673044: Adds the new inspector widget into the tree

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by jeff.pihach
Modified:
10 years, 10 months ago
Reviewers:
mp+165248, bac, gary.poster
Visibility:
Public.

Description

Adds the new inspector widget into the tree This is the new widget which will be used to render the inspector and various other nested views for the coming UI changes. No QA necessary as it has no client facing changes in this branch. https://code.launchpad.net/~hatch/juju-gui/inspector-widget/+merge/165248 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 9

Patch Set 2 : Adds the new inspector widget into the tree #

Patch Set 3 : Adds the new inspector widget into the tree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+444 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 chunk +2 lines, -1 line 0 comments Download
M app/modules-debug.js View 1 chunk +4 lines, -0 lines 0 comments Download
A app/widgets/inspector-widget.js View 1 1 chunk +229 lines, -0 lines 0 comments Download
A lib/views/juju-inspector.less View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/views/stylesheet.less View 3 chunks +4 lines, -1 line 0 comments Download
M test/index.html View 1 chunk +1 line, -0 lines 0 comments Download
A test/test_inspector_widget.js View 1 1 chunk +196 lines, -0 lines 0 comments Download

Messages

Total messages: 6
jeff.pihach
Please take a look.
10 years, 10 months ago (2013-05-22 20:53:05 UTC) #1
bac
LGTM Jeff, with some questions and suggestions for improved descriptions. Look forward to seeing this ...
10 years, 10 months ago (2013-05-22 21:01:48 UTC) #2
jeff.pihach
Thanks for the review changes coming soon. https://codereview.appspot.com/9673044/diff/1/app/widgets/inspector-widget.js File app/widgets/inspector-widget.js (right): https://codereview.appspot.com/9673044/diff/1/app/widgets/inspector-widget.js#newcode4 app/widgets/inspector-widget.js:4: Copyright (C) ...
10 years, 10 months ago (2013-05-22 21:07:19 UTC) #3
jeff.pihach
Please take a look.
10 years, 10 months ago (2013-05-22 21:11:39 UTC) #4
gary.poster
LGTM! very nice, thank you. Gary https://codereview.appspot.com/9673044/diff/1/app/widgets/inspector-widget.js File app/widgets/inspector-widget.js (right): https://codereview.appspot.com/9673044/diff/1/app/widgets/inspector-widget.js#newcode22 app/widgets/inspector-widget.js:22: Adds the Inspector ...
10 years, 10 months ago (2013-05-22 21:14:39 UTC) #5
jeff.pihach
10 years, 10 months ago (2013-05-22 22:31:07 UTC) #6
*** Submitted:

Adds the new inspector widget into the tree

This is the new widget which will be used to render the
inspector and various other nested views for the coming
UI changes. No QA necessary as it has no client facing
changes in this branch.

R=bac, gary.poster
CC=
https://codereview.appspot.com/9673044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b