Issue 9665046: code review 9665046: runtime: update comment on stack allocator

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9665046: code review 9665046: runtime: update comment on stack allocator (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by dvyukov

Modified:
12 years, 1 month ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

runtime: update comment on stack allocator

Patch Set 2 : diff -r 2a106010f660 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 2a106010f660 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 3

Patch Set 4 : diff -r 2a106010f660 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 2a106010f660 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 2a106010f660 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	src/pkg/runtime/stack.c	View	1 2 3 4	1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 1 month ago (2013-05-25 17:47:24 UTC) #1

LGTM, just a little englishtweakingness https://codereview.appspot.com/9665046/diff/5001/src/pkg/runtime/stack.c File src/pkg/runtime/stack.c (right): https://codereview.appspot.com/9665046/diff/5001/src/pkg/runtime/stack.c#newcode87 src/pkg/runtime/stack.c:87: // so that we ...

12 years, 1 month ago (2013-05-25 18:29:46 UTC) #2

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=ca166884c853 *** runtime: update comment on stack allocator R=golang-dev, r CC=golang-dev https://codereview.appspot.com/9665046 ...

12 years, 1 month ago (2013-05-25 18:47:46 UTC) #3

dvyukov

12 years, 1 month ago (2013-05-25 18:48:40 UTC) #5

Message was sent while issue was closed.

https://codereview.appspot.com/9665046/diff/5001/src/pkg/runtime/stack.c
File src/pkg/runtime/stack.c (right):

https://codereview.appspot.com/9665046/diff/5001/src/pkg/runtime/stack.c#newc...
src/pkg/runtime/stack.c:87: // so that we do not deadlock).
On 2013/05/25 18:47:46, dvyukov wrote:
> On 2013/05/25 18:29:46, r wrote:
> > Stacks are usually allocated with a fixed-size free-list allocator, but if
we
> > need a stack of non-standard...
> 
> Done.

Done.

Expand All Messages | Collapse All Messages