Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 96510044: JAVA/CPP: Handle phone number input in RFC3966 with missing "tel:" prefix. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Shaopeng
Modified:
6 years, 5 months ago
Reviewers:
davinci_google
Base URL:
http://libphonenumber.googlecode.com/svn/trunk/
Visibility:
Public.

Description

JAVA/CPP: Handle phone number input in RFC3966 with missing "tel:" prefix. Committed: https://code.google.com/p/libphonenumber/source/detail?r=664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M cpp/src/phonenumbers/phonenumberutil.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M cpp/test/phonenumbers/phonenumberutil_test.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java View 1 chunk +7 lines, -3 lines 0 comments Download
M java/libphonenumber/test/com/google/i18n/phonenumbers/PhoneNumberUtilTest.java View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
shaopengjia
Syncing internal change to external.
6 years, 5 months ago (2014-05-20 12:19:22 UTC) #1
davinci_google
On 2014/05/20 12:19:22, shaopengjia wrote: > Syncing internal change to external. LGTM
6 years, 5 months ago (2014-05-20 12:20:27 UTC) #2
Shaopeng
6 years, 5 months ago (2014-05-20 12:34:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r664 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b