Issue 96510044: JAVA/CPP: Handle phone number input in RFC3966 with missing "tel:" prefix.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96510044: JAVA/CPP: Handle phone number input in RFC3966 with missing "tel:" prefix. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by Shaopeng

Modified:
9 years, 11 months ago

Reviewers:
davinci_google

Base URL:
http://libphonenumber.googlecode.com/svn/trunk/

Visibility:
Public.

JAVA/CPP: Handle phone number input in RFC3966 with missing "tel:" prefix. Committed: https://code.google.com/p/libphonenumber/source/detail?r=664

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -8 lines)			Patch
M	cpp/src/phonenumbers/phonenumberutil.cc	View	1 chunk	+9 lines, -5 lines	0 comments	Download
M	cpp/test/phonenumbers/phonenumberutil_test.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	java/libphonenumber/test/com/google/i18n/phonenumbers/PhoneNumberUtilTest.java	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 3

davinci_google

On 2014/05/20 12:19:22, shaopengjia wrote: > Syncing internal change to external. LGTM

9 years, 11 months ago (2014-05-20 12:20:27 UTC) #2

Shaopeng

9 years, 11 months ago (2014-05-20 12:34:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r664 (presubmit successful).