Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(994)

Issue 9642043: Improve CI test runner.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by frankban
Modified:
10 years, 10 months ago
Reviewers:
mp+165080, teknico, gary.poster
Visibility:
Public.

Description

Improve CI test runner. bin/test-charm refactoring. Improved error handling. Ensure the environment is destroyed when an error occurs during deployment. Also added a way to reuse the juju environment while coding/debugging. Fixed the Firefox version used in Saucelabs. Running with a specific Firefox version is still required, but now we know why: the default Saucelab version (11) is not supported by Juju GUI. This branch also includes some lint/pep8 fixes. https://code.launchpad.net/~frankban/juju-gui/firefox-version/+merge/165080 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 10

Patch Set 2 : Improve CI test runner. #

Total comments: 4

Patch Set 3 : Improve CI test runner. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -47 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M bin/test-charm View 1 2 1 chunk +76 lines, -35 lines 0 comments Download
M docs/continuous-integration.rst View 1 2 chunks +28 lines, -5 lines 0 comments Download
M lib/deploy_charm_for_testing.py View 5 chunks +7 lines, -2 lines 0 comments Download
M test/browser.py View 4 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
10 years, 10 months ago (2013-05-22 11:45:46 UTC) #1
gary.poster
LGTM. Very nice, thank you! Just a few doc suggestions. Feel free to edit them. ...
10 years, 10 months ago (2013-05-22 12:35:44 UTC) #2
frankban
Please take a look. https://codereview.appspot.com/9642043/diff/1/bin/test-charm File bin/test-charm (right): https://codereview.appspot.com/9642043/diff/1/bin/test-charm#newcode1 bin/test-charm:1: #!/bin/sh On 2013/05/22 12:35:44, gary.poster ...
10 years, 10 months ago (2013-05-22 13:23:29 UTC) #3
teknico
LGTM, nice branch, thanks. See trivials below. https://codereview.appspot.com/9642043/diff/6001/bin/test-charm File bin/test-charm (right): https://codereview.appspot.com/9642043/diff/6001/bin/test-charm#newcode30 bin/test-charm:30: # rather ...
10 years, 10 months ago (2013-05-22 14:02:42 UTC) #4
frankban
*** Submitted: Improve CI test runner. bin/test-charm refactoring. Improved error handling. Ensure the environment is ...
10 years, 10 months ago (2013-05-22 14:38:03 UTC) #5
frankban
10 years, 10 months ago (2013-05-22 14:40:13 UTC) #6
Thank you both for the reviews!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b