Issue 96360045: goose: fix vet errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96360045: goose: fix vet errors

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by dave

Modified:
9 years, 11 months ago

Reviewers:
mp+219781, axw

Visibility:
Public.

Description

goose: fix vet errors * fix several printf errors * address unreachable code warnings. Rewrote branches to avoid unreachable code while being compatible with Go 1.0 https://code.launchpad.net/~dave-cheney/goose/100-fix-vet-errors/+merge/219781 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -25 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	nova/json.go	View	1 chunk	+8 lines, -9 lines	0 comments	Download
M	testservices/cmd/main.go	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	testservices/identityservice/keypair.go	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	testservices/identityservice/userpass.go	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	testservices/novaservice/service_http.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/secgroup-delete-all/main_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw

9 years, 11 months ago (2014-05-16 06:31:32 UTC) #2

On 2014/05/16 06:17:54, dfc wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages