Issue 96360043: code review 96360043: crypto/sha256, crypto/sha512: fix argument size in assembly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96360043: code review 96360043: crypto/sha256, crypto/sha512: fix argument size in assembly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by rsc

Modified:
10 years, 11 months ago

Reviewers:
bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

crypto/sha256, crypto/sha512: fix argument size in assembly The function takes 32 bytes of arguments: 8 for the *block and then 3*8 for the slice. The 24 is not causing a bug (today at least) because the final word is the cap of the slice, which the assembly does not use. Identified by 'go vet std'.

Patch Set 1 #

Patch Set 2 : diff -r 712f6b41d382 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 712f6b41d382 https://code.google.com/p/go/ #

Patch Set 4 : diff -r b10044024a6d https://code.google.com/p/go/ #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/crypto/sha256/sha256block_amd64.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/crypto/sha512/sha512block_amd64.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years, 11 months ago (2014-05-15 15:53:33 UTC) #1

bradfitz

LGTM On Thu, May 15, 2014 at 8:53 AM, <rsc@golang.org> wrote: > Reviewers: golang-codereviews, > ...

10 years, 11 months ago (2014-05-15 16:01:13 UTC) #2

LGTM



On Thu, May 15, 2014 at 8:53 AM, <rsc@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> crypto/sha256, crypto/sha512: fix argument size in assembly
>
> The function takes 32 bytes of arguments: 8 for the *block
> and then 3*8 for the slice.
>
> The 24 is not causing a bug (today at least) because the
> final word is the cap of the slice, which the assembly
> does not use.
>
> Identified by 'go vet std'.
>
> Please review this at https://codereview.appspot.com/96360043/
>
> Affected files (+2, -2 lines):
>   M src/pkg/crypto/sha256/sha256block_amd64.s
>   M src/pkg/crypto/sha512/sha512block_amd64.s
>
>
> Index: src/pkg/crypto/sha256/sha256block_amd64.s
> ===================================================================
> --- a/src/pkg/crypto/sha256/sha256block_amd64.s
> +++ b/src/pkg/crypto/sha256/sha256block_amd64.s
> @@ -140,7 +140,7 @@
>         MSGSCHEDULE1(index); \
>         SHA256ROUND(index, const, a, b, c, d, e, f, g, h)
>
> -TEXT ·block(SB),0,$264-24
> +TEXT ·block(SB),0,$264-32
>         MOVQ    p_base+8(FP), SI
>         MOVQ    p_len+16(FP), DX
>         SHRQ    $6, DX
> Index: src/pkg/crypto/sha512/sha512block_amd64.s
> ===================================================================
> --- a/src/pkg/crypto/sha512/sha512block_amd64.s
> +++ b/src/pkg/crypto/sha512/sha512block_amd64.s
> @@ -141,7 +141,7 @@
>         MSGSCHEDULE1(index); \
>         SHA512ROUND(index, const, a, b, c, d, e, f, g, h)
>
> -TEXT ·block(SB),0,$648-24
> +TEXT ·block(SB),0,$648-32
>         MOVQ    p_base+8(FP), SI
>         MOVQ    p_len+16(FP), DX
>         SHRQ    $7, DX
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

rsc

10 years, 11 months ago (2014-05-15 19:34:28 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=9b16dca7541d ***

crypto/sha256, crypto/sha512: fix argument size in assembly

The function takes 32 bytes of arguments: 8 for the *block
and then 3*8 for the slice.

The 24 is not causing a bug (today at least) because the
final word is the cap of the slice, which the assembly
does not use.

Identified by 'go vet std'.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/96360043

Expand All Messages | Collapse All Messages