Issue 96320045: Issue 464: Error when setting an invalid etag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96320045: Issue 464: Error when setting an invalid etag (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by peleyal

Modified:
10 years, 7 months ago

Reviewers:
class

CC:
google-api-dotnet-client_googlegroups.com

Base URL:
https://google-api-dotnet-client.googlecode.com/hg/

Visibility:
Public.

More Reviews

Description

Issue 464: Error when setting an invalid etag

Patch Set 2 : Don't fix etag - Just log #

Total comments: 2

Patch Set 3 : minor #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -8 lines)			Patch
	M	Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
	M	Src/GoogleApis/Apis/Requests/ClientServiceRequest.cs	View	1	2 chunks	+17 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

class

https://codereview.appspot.com/96320045/diff/20001/Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs File Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs (right): https://codereview.appspot.com/96320045/diff/20001/Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs#newcode1149 Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs:1149: // Etag doesn't contain quotas - catching the exception ...

10 years, 7 months ago (2014-05-15 18:07:54 UTC) #2

peleyal

10 years, 7 months ago (2014-05-15 22:08:49 UTC) #3

I'll commit it now.
Thanks!

https://codereview.appspot.com/96320045/diff/20001/Src/GoogleApis.Tests/Apis/...
File Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs (right):

https://codereview.appspot.com/96320045/diff/20001/Src/GoogleApis.Tests/Apis/...
Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs:1149: // Etag
doesn't contain quotas - catching the exception and log.
On 2014/05/15 18:07:53, class wrote:
> "catching the exception and log."
> 
> Switch to either "catching the exception and logging." or "catch the exception
> and log"

Done.

Expand All Messages | Collapse All Messages