Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1509)

Issue 96320045: Issue 464: Error when setting an invalid etag (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by peleyal
Modified:
5 years, 4 months ago
Reviewers:
class
CC:
google-api-dotnet-client_googlegroups.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 464: Error when setting an invalid etag

Patch Set 1 #

Patch Set 2 : Don't fix etag - Just log #

Total comments: 2

Patch Set 3 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M Src/GoogleApis/Apis/Requests/ClientServiceRequest.cs View 1 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 3
peleyal
And another small one :)
5 years, 4 months ago (2014-05-15 17:35:34 UTC) #1
class
https://codereview.appspot.com/96320045/diff/20001/Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs File Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs (right): https://codereview.appspot.com/96320045/diff/20001/Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs#newcode1149 Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs:1149: // Etag doesn't contain quotas - catching the exception ...
5 years, 4 months ago (2014-05-15 18:07:54 UTC) #2
peleyal
5 years, 4 months ago (2014-05-15 22:08:49 UTC) #3
I'll commit it now.
Thanks!

https://codereview.appspot.com/96320045/diff/20001/Src/GoogleApis.Tests/Apis/...
File Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs (right):

https://codereview.appspot.com/96320045/diff/20001/Src/GoogleApis.Tests/Apis/...
Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs:1149: // Etag
doesn't contain quotas - catching the exception and log.
On 2014/05/15 18:07:53, class wrote:
> "catching the exception and log."
> 
> Switch to either "catching the exception and logging." or "catch the exception
> and log"

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b