Issue 96290043: code review 96290043: cmd/go: detect import cycle caused by test code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96290043: code review 96290043: cmd/go: detect import cycle caused by test code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by rsc

Modified:
10 years, 12 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

cmd/go: detect import cycle caused by test code The runtime was detecting the cycle already, but we can give a better error without even building the binary. Fixes issue 7789.

Patch Set 1 #

Patch Set 2 : diff -r 06d8b8553a44 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5d4d29c225e6 https://code.google.com/p/go/ #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -2 lines)			Patch
M	src/cmd/go/pkg.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/go/test.bash	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/cmd/go/test.go	View	1	2 chunks	+32 lines, -1 line	0 comments	Download
A	src/cmd/go/testdata/src/testcycle/p1/p1.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
A	src/cmd/go/testdata/src/testcycle/p1/p1_test.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
A	src/cmd/go/testdata/src/testcycle/p2/p2.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
A	src/cmd/go/testdata/src/testcycle/p3/p3.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	src/cmd/go/testdata/src/testcycle/p3/p3_test.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years, 12 months ago (2014-05-12 19:08:30 UTC) #1

rsc

10 years, 12 months ago (2014-05-12 20:52:59 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=e39354658276 ***

cmd/go: detect import cycle caused by test code

The runtime was detecting the cycle already,
but we can give a better error without even
building the binary.

Fixes issue 7789.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/96290043

Expand All Messages | Collapse All Messages