Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 96220049: code review 96220049: undo CL 92210044 / 5cb21eee2d35 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by bradfitz
Modified:
11 years, 4 months ago
Reviewers:
mikio, iant
CC:
golang-codereviews
Visibility:
Public.

Description

undo CL 92210044 / 5cb21eee2d35 <enter reason for undo> ««« original CL description net: make use of SO_LINGER_SEC on darwin Fixes issue 7971. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://codereview.appspot.com/92210044 »»»

Patch Set 1 #

Patch Set 2 : diff -r 5cb21eee2d35 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5cb21eee2d35 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M src/pkg/net/sockopt_posix.go View 1 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 4 months ago (2014-05-12 15:48:11 UTC) #1
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=0c0e66a3fca8 *** undo CL 92210044 / 5cb21eee2d35 <enter reason for undo> ««« ...
11 years, 4 months ago (2014-05-12 15:48:22 UTC) #2
iant
LGTM Sorry, I should have realized that code would fail.
11 years, 4 months ago (2014-05-12 16:04:08 UTC) #3
mikio
11 years, 4 months ago (2014-05-12 17:02:57 UTC) #4
LGTM

sorry about that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b