Issue 96190043: utils/syslog: log to all state machines

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96190043: utils/syslog: log to all state machines

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by wwitzel

Modified:
9 years, 11 months ago

Reviewers:
mp+217208, wwitzel3, natefinch

Visibility:
Public.

Description

utils/syslog: log to all state machines https://code.launchpad.net/~wwitzel3/juju-core/008-ha-rsyslog/+merge/217208 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : utils/syslog: log to all state machines #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -38 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	utils/syslog/config.go	View		3 chunks	+34 lines, -27 lines	1 comment	Download
M	utils/syslog/testing/syslogconf.go	View		1 chunk	+12 lines, -11 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

wwitzel3

Keep in mind that I will working with Curtis to get tests for this in ...

9 years, 11 months ago (2014-05-12 14:26:09 UTC) #3

natefinch

LGTM I guess. I don't know the rsyslog format, though, so can't really critique it. ...

9 years, 11 months ago (2014-05-12 15:24:16 UTC) #4

wwitzel3

9 years, 11 months ago (2014-05-12 15:59:18 UTC) #5

On 2014/05/12 15:24:16, nate.finch wrote:
> LGTM I guess.  I don't know the rsyslog format, though, so can't really
critique
> it.  I understand the changes and they look sane as far as that is concerned.
> 

Tested working in non-HA and HA mode with EC2, MAAS, and Canonistack.

> https://codereview.appspot.com/96190043/diff/20001/utils/syslog/config.go
> File utils/syslog/config.go (right):
> 
>
https://codereview.appspot.com/96190043/diff/20001/utils/syslog/config.go#new...
> utils/syslog/config.go:213: var stateServerHosts = func() []string {
> note that you can make this stateServerHosts := func() []string { and drop the
> var.  Doesn't need to be fixed, just saying for future reference.

Right. Makes sense.

Expand All Messages | Collapse All Messages