Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(515)

Issue 96140044: Introduce lxc-use-clone, ContainerManagerConfig

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by axw
Modified:
5 years, 9 months ago
Reviewers:
mp+218773, wallyworld, fwereade
Visibility:
Public.

Description

Introduce lxc-use-clone, ContainerManagerConfig A new lxc-use-clone config attribute and a new ContainerManagerConfig provisioner API are introduced. If lxc-use-clone is set to true, then the LXC provisioner will be configured to use cloning regardless of provider type. This setting is currently immutable; additional work will be required to support reacting to changes and reconfiguring the provisioner. Fixes lp:1315216 https://code.launchpad.net/~axwalk/juju-core/lp1315216-lxc-use-clone/+merge/218773 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Introduce lxc-use-clone, ContainerManagerConfig #

Patch Set 3 : Introduce lxc-use-clone, ContainerManagerConfig #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -15 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M environs/config/config.go View 4 chunks +13 lines, -3 lines 0 comments Download
M environs/config/config_test.go View 1 2 chunks +6 lines, -0 lines 0 comments Download
M state/api/params/params.go View 1 chunk +12 lines, -0 lines 0 comments Download
M state/api/provisioner/provisioner.go View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M state/api/provisioner/provisioner_test.go View 1 2 chunks +54 lines, -0 lines 0 comments Download
M state/apiserver/provisioner/provisioner.go View 1 2 2 chunks +20 lines, -1 line 0 comments Download
M state/apiserver/provisioner/provisioner_test.go View 1 2 chunks +10 lines, -0 lines 0 comments Download
M worker/provisioner/container_initialisation.go View 4 chunks +19 lines, -3 lines 0 comments Download
M worker/provisioner/kvm-broker.go View 1 chunk +2 lines, -1 line 0 comments Download
M worker/provisioner/kvm-broker_test.go View 3 chunks +5 lines, -2 lines 0 comments Download
M worker/provisioner/lxc-broker.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/provisioner/lxc-broker_test.go View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7
axw
Please take a look.
5 years, 9 months ago (2014-05-08 10:03:42 UTC) #1
wallyworld
Thanks very much for picking this up. We need tests for the new api calls ...
5 years, 9 months ago (2014-05-08 10:43:00 UTC) #2
fwereade
ISTM that there's no code to handle immutability of use-lxc-clone. If we're not properly handling ...
5 years, 9 months ago (2014-05-08 11:52:43 UTC) #3
axw
Please take a look.
5 years, 9 months ago (2014-05-09 01:49:28 UTC) #4
axw
On 2014/05/08 11:52:43, fwereade wrote: > ISTM that there's no code to handle immutability of ...
5 years, 9 months ago (2014-05-09 01:50:54 UTC) #5
axw
On 2014/05/08 10:43:00, wallyworld wrote: > Thanks very much for picking this up. We need ...
5 years, 9 months ago (2014-05-09 01:51:45 UTC) #6
axw
5 years, 9 months ago (2014-05-09 02:01:05 UTC) #7
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b