Introduce lxc-use-clone, ContainerManagerConfig

Introduce lxc-use-clone, ContainerManagerConfig

A new lxc-use-clone config attribute and a new
ContainerManagerConfig provisioner API are introduced.
If lxc-use-clone is set to true, then the LXC
provisioner will be configured to use cloning
regardless of provider type. This setting is currently
immutable; additional work will be required to support
reacting to changes and reconfiguring the provisioner.

Fixes lp:1315216

https://code.launchpad.net/~axwalk/juju-core/lp1315216-lxc-use-clone/+merge/218773

(do not edit description out of merge proposal)

[axw, 2014-05-08 10:03:42]

Please take a look.

[wallyworld, 2014-05-08 10:43:00]

Thanks very much for picking this up. We need tests for the new api calls and
also possibly the new code in container_initialisation. So long as it's been
tested with lxc-use-clone set to true and false, LGTM

https://codereview.appspot.com/96140044/diff/1/state/api/provisioner/provisio...
File state/api/provisioner/provisioner.go (right):

https://codereview.appspot.com/96140044/diff/1/state/api/provisioner/provisio...
state/api/provisioner/provisioner.go:118: func (st *State)
ContainerManagerConfig(args params.ContainerManagerConfigParams) (result
params.ContainerManagerConfig, err error) {
Need a doc comment

https://codereview.appspot.com/96140044/diff/1/state/apiserver/provisioner/pr...
File state/apiserver/provisioner/provisioner.go (right):

https://codereview.appspot.com/96140044/diff/1/state/apiserver/provisioner/pr...
state/apiserver/provisioner/provisioner.go:194: // ContainerManagerConfig
returns information from the environment config that are
that is needed

[fwereade, 2014-05-08 11:52:43]

ISTM that there's no code to handle immutability of use-lxc-clone. If we're not
properly handling changes yet, let's disallow them until we have the
infrastructure for it.

[axw, 2014-05-09 01:49:28]

Please take a look.

[axw, 2014-05-09 01:50:54]

On 2014/05/08 11:52:43, fwereade wrote:
> ISTM that there's no code to handle immutability of use-lxc-clone. If we're
not
> properly handling changes yet, let's disallow them until we have the
> infrastructure for it.

It was already immutable; I've added a test to make it clear.

[axw, 2014-05-09 01:51:45]

On 2014/05/08 10:43:00, wallyworld wrote:
> Thanks very much for picking this up. We need tests for the new api calls and
> also possibly the new code in container_initialisation. So long as it's been
> tested with lxc-use-clone set to true and false, LGTM

Added unit tests. I have run it live, doing it once more before landing.

>
https://codereview.appspot.com/96140044/diff/1/state/api/provisioner/provisio...
> File state/api/provisioner/provisioner.go (right):
> 
>
https://codereview.appspot.com/96140044/diff/1/state/api/provisioner/provisio...
> state/api/provisioner/provisioner.go:118: func (st *State)
> ContainerManagerConfig(args params.ContainerManagerConfigParams) (result
> params.ContainerManagerConfig, err error) {
> Need a doc comment
> 
>
https://codereview.appspot.com/96140044/diff/1/state/apiserver/provisioner/pr...
> File state/apiserver/provisioner/provisioner.go (right):
> 
>
https://codereview.appspot.com/96140044/diff/1/state/apiserver/provisioner/pr...
> state/apiserver/provisioner/provisioner.go:194: // ContainerManagerConfig
> returns information from the environment config that are
> that is needed

[axw, 2014-05-09 02:01:05]

Please take a look.