Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(357)

Issue 9611048: code review 9611048: cmd/go: support new location for vet (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by r
Modified:
12 years, 1 month ago
Reviewers:
rsc
CC:
rsc, ioe, golang-dev
Visibility:
Public.

Description

cmd/go: support new location for vet Also delete the special case for exp, which isn't necessary any more. Fixes issue 5529.

Patch Set 1 #

Patch Set 2 : diff -r 45732d262481 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M src/cmd/go/pkg.go View 2 chunks +6 lines, -6 lines 0 comments Download
M src/cmd/go/tool.go View 3 chunks +24 lines, -10 lines 0 comments Download

Messages

Total messages: 5
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 1 month ago (2013-05-21 22:05:35 UTC) #1
ioe
Could you confirm, that one can now build, package and install Go into to system ...
12 years, 1 month ago (2013-05-21 22:23:46 UTC) #2
r
I'm not sure what you're asking, but I think it's what this CL does: install ...
12 years, 1 month ago (2013-05-21 22:35:05 UTC) #3
rsc
LGTM
12 years, 1 month ago (2013-05-21 23:43:06 UTC) #4
r
12 years, 1 month ago (2013-05-22 04:18:18 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=4bd7beaedee8 ***

cmd/go: support new location for vet
Also delete the special case for exp, which isn't necessary any more.

Fixes issue 5529.

R=rsc, nightlyone
CC=golang-dev
https://codereview.appspot.com/9611048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b