code review 9611045: build: fix make.rc on Plan 9

build: fix make.rc on Plan 9

Set $status as null to prevent rc from exiting
on the last --no-banner argument checking when
used with rc -e. It allows all.rc to not exit
before executing run.rc

[0intro, 2013-05-21 06:21:10]

Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[lucio, 2013-05-21 06:29:36]

I actually added

echo '# make.rc complete.'

instead of your "if not", I'm mentioning it here in case others also
find it preferable.

Lucio.


On 5/21/13, 0intro@gmail.com <0intro@gmail.com> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> build: fix make.rc on Plan 9
>
> Set $status as null to prevent rc from exiting
> on the last --no-banner argument checking when
> used with rc -e. It allows all.rc to not exit
> before executing run.rc
>
> Please review this at https://codereview.appspot.com/9611045/
>
> Affected files:
>    M src/make.rc
>
>
> Index: src/make.rc
> ===================================================================
> --- a/src/make.rc
> +++ b/src/make.rc
> @@ -95,3 +95,5 @@
>
>   if(! ~ $1 --no-banner)
>   	$GOTOOLDIR/dist banner
> +if not
> +	status=''
>
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>

[rsc, 2013-05-24 19:00:01]

if not
    status=''

is identical in meaning to

status=''

[0intro, 2013-05-24 19:19:49]

Hello golang-dev@googlegroups.com, lucio.dere@gmail.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2013-05-24 20:55:24]

LGTM

[r, 2013-05-24 20:55:25]

*** Submitted as https://code.google.com/p/go/source/detail?r=9b11496e569e ***

build: fix make.rc on Plan 9

Set $status as null to prevent rc from exiting
on the last --no-banner argument checking when
used with rc -e. It allows all.rc to not exit
before executing run.rc

R=golang-dev, lucio.dere, rsc
CC=golang-dev
https://codereview.appspot.com/9611045

Committer: Rob Pike <r@golang.org>