Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 96000043: code review 96000043: tag go1.2.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by adg
Modified:
11 years ago
Reviewers:
gobot, dave, iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

tag go1.2.2

Patch Set 1 #

Patch Set 2 : diff -r 51dc50080c9f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M .hgtags View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
adg
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years ago (2014-05-05 17:44:21 UTC) #1
iant
LGTM
11 years ago (2014-05-05 17:44:58 UTC) #2
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=76b34f313306 *** tag go1.2.2 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://codereview.appspot.com/96000043
11 years ago (2014-05-05 17:46:00 UTC) #3
gobot
This CL appears to have broken the darwin-amd64-cheney builder. See http://build.golang.org/log/f07a9cb0cb3de63dd3750e352e9401a60d0e4b07
11 years ago (2014-05-05 23:23:15 UTC) #4
dave_cheney.net
11 years ago (2014-05-05 23:25:30 UTC) #5
Please ignore. This builder decided to apply some updates from apple,
and although I told it not to reboot, it appeared to have shut down
some system services.

I have rebooted the machine

On Tue, May 6, 2014 at 9:23 AM,  <gobot@golang.org> wrote:
> This CL appears to have broken the darwin-amd64-cheney builder.
> See http://build.golang.org/log/f07a9cb0cb3de63dd3750e352e9401a60d0e4b07
>
>
> https://codereview.appspot.com/96000043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b