Issue 9599044: code review 9599044: spec: removed old or invalid TODOs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9599044: code review 9599044: spec: removed old or invalid TODOs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by gri

Modified:
12 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

spec: removed old or invalid TODOs Several old TODOs are either resolved now (e.g. when is a return needed), or are from a time the language wasn't frozen (^ for uints only). Consolidated the others.

Patch Set 1 #

Patch Set 2 : diff -r cfc3bd387c6a https://code.google.com/p/go #

Patch Set 3 : diff -r cfc3bd387c6a https://code.google.com/p/go #

Patch Set 4 : diff -r cfc3bd387c6a https://code.google.com/p/go #

Patch Set 5 : diff -r cfc3bd387c6a https://code.google.com/p/go #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -30 lines)			Patch
	M	doc/go_spec.html	View	1	5 chunks	+1 line, -30 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years ago (2013-05-20 20:34:59 UTC) #1

gri

Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years ago (2013-05-20 20:58:41 UTC) #3

gri

please ignore - typed 'mail' instead of 'submit' - gri On Mon, May 20, 2013 ...

12 years ago (2013-05-20 21:00:58 UTC) #4

gri

12 years ago (2013-05-20 21:01:10 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=7d87f5bc43b6 ***

spec: removed old or invalid TODOs

Several old TODOs are either resolved now (e.g. when is a return
needed), or are from a time the language wasn't frozen (^ for uints
only). Consolidated the others.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/9599044

Expand All Messages | Collapse All Messages