Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(508)

Issue 9593044: Fix assorted annoyances

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by gary.poster
Modified:
10 years, 11 months ago
Reviewers:
frankban, teknico, mp+164826
Visibility:
Public.

Description

Fix assorted annoyances - Make simulation turned off by default, but available if you use :flags:/simulateEvents in the URL. - fix the sizing of the service page. we're going to replace these pages soon, but the experience should not be awful before then. - switch the default charmworld URL to manage.charmworld.com. It is a better default (more reliable) than staging these days. https://code.launchpad.net/~gary/juju-gui/hack/+merge/164826 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix assorted annoyances #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -19 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 6 chunks +46 lines, -12 lines 0 comments Download
M app/config-debug.js View 2 chunks +3 lines, -2 lines 0 comments Download
M app/config-prod.js View 2 chunks +4 lines, -1 line 0 comments Download
M app/views/service.js View 3 chunks +13 lines, -3 lines 0 comments Download
M test/test_service_view.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
gary.poster
Please take a look.
10 years, 11 months ago (2013-05-21 02:22:14 UTC) #1
frankban
LGTM, thank you Gary! The feature flag works great. https://codereview.appspot.com/9593044/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/9593044/diff/1/app/app.js#newcode1119 app/app.js:1119: ...
10 years, 11 months ago (2013-05-21 08:31:41 UTC) #2
teknico
LGTM
10 years, 11 months ago (2013-05-21 10:41:42 UTC) #3
gary.poster
*** Submitted: Fix assorted annoyances - Make simulation turned off by default, but available if ...
10 years, 11 months ago (2013-05-21 12:28:25 UTC) #4
gary.poster
10 years, 11 months ago (2013-05-21 12:30:16 UTC) #5
Thank you both for the reviews!

Gary
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b