code review 95930044: go.image/tiff: Support missing Compression tag

go.image/tiff: Support missing Compression tag

no_compress.tiff is no_rps.tiff that was read in by go.image/tiff and written out again (with a hack to avoid creating the Compression tag on the way out).

$ tiffdump no_compress.tiff 
no_compress.tiff:
Magic: 0x4949 <little-endian> Version: 0x2a
Directory 0: offset 968 (0x3c8) next 0 (0)
ImageWidth (256) SHORT (3) 1<16>
ImageLength (257) SHORT (3) 1<15>
BitsPerSample (258) SHORT (3) 4<8 8 8 8>
Photometric (262) SHORT (3) 1<2>
StripOffsets (273) LONG (4) 1<8>
SamplesPerPixel (277) SHORT (3) 1<4>
RowsPerStrip (278) SHORT (3) 1<15>
StripByteCounts (279) LONG (4) 1<960>
XResolution (282) RATIONAL (5) 1<72>
YResolution (283) RATIONAL (5) 1<72>
ResolutionUnit (296) SHORT (3) 1<2>
ExtraSamples (338) SHORT (3) 1<2>

[pfr, 2014-05-02 15:55:17]

Hello bsiegert@gmail.com, nigeltao@golang.org (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.image

[bsiegert, 2014-05-03 16:06:42]

LGTM

Thanks for this. The tiff package was written according to the specification, so
support for files that are technically broken but accepted by other tools is
weak at the moment.

[pfr, 2014-05-05 17:31:58]

On 2014/05/03 16:06:42, bsiegert wrote:
> LGTM
> 
> Thanks for this. The tiff package was written according to the specification,
so
> support for files that are technically broken but accepted by other tools is
> weak at the moment.

I don't think I have submission permissions -- Benny, are you going to patch and
submit?

[bsiegert, 2014-05-05 18:14:57]

We need to wait for nigeltao.
On lun. 5 mai 2014 um 7:31 PM, <pfr@google.com> wrote:

> On 2014/05/03 16:06:42, bsiegert wrote:
> > LGTM
>
> > Thanks for this. The tiff package was written according to the
> specification, so
> > support for files that are technically broken but accepted by other
> tools is
> > weak at the moment.
>
> I don't think I have submission permissions -- Benny, are you going to
> patch and submit?
>
> https://codereview.appspot.com/95930044/
>

[nigeltao, 2014-05-06 13:46:10]

Code looks fine. Any copyright issues with no_compress.tiff? Sorry if the
answer's trivial, but codereview isn't showing it.

[pfr, 2014-05-06 16:33:05]

no_compress.tiff is no_rps.tiff that was read in by go.image/tiff and
written out again (with a hack to avoid creating the Compression tag on the
way out).

I've updated the CL description to reflect this.


On Tue, May 6, 2014 at 6:46 AM, <nigeltao@golang.org> wrote:

> Code looks fine. Any copyright issues with no_compress.tiff? Sorry if
> the answer's trivial, but codereview isn't showing it.
>
> https://codereview.appspot.com/95930044/
>



-- 
Patrick Riley
pfr@google.com

[nigeltao, 2014-05-07 02:28:39]

LGTM.

[nigeltao, 2014-05-12 06:42:05]

*** Submitted as
https://code.google.com/p/go/source/detail?r=d78170223cde&repo=image ***

go.image/tiff: Support missing Compression tag

no_compress.tiff is no_rps.tiff that was read in by go.image/tiff and written
out again (with a hack to avoid creating the Compression tag on the way out).

$ tiffdump no_compress.tiff
no_compress.tiff:
Magic: 0x4949 <little-endian> Version: 0x2a
Directory 0: offset 968 (0x3c8) next 0 (0)
ImageWidth (256) SHORT (3) 1<16>
ImageLength (257) SHORT (3) 1<15>
BitsPerSample (258) SHORT (3) 4<8 8 8 8>
Photometric (262) SHORT (3) 1<2>
StripOffsets (273) LONG (4) 1<8>
SamplesPerPixel (277) SHORT (3) 1<4>
RowsPerStrip (278) SHORT (3) 1<15>
StripByteCounts (279) LONG (4) 1<960>
XResolution (282) RATIONAL (5) 1<72>
YResolution (283) RATIONAL (5) 1<72>
ResolutionUnit (296) SHORT (3) 1<2>
ExtraSamples (338) SHORT (3) 1<2>

LGTM=bsiegert, nigeltao
R=bsiegert, nigeltao
CC=golang-codereviews
https://codereview.appspot.com/95930044

Committer: Nigel Tao <nigeltao@golang.org>