Add authentication CI tests.

Add authentication CI tests.

This branch introduces CI tests for the authentication 
infrastructure. Login/logout process is tested from
root and from detail pages, as discussed in a pre-imp
call with Jeff.

Fixed a bug preventing the user to logout from a detail
page if that page was directly accessed.

Also improved testing using a local Selenium driver.
As described in the docs, now it is possible to
pass a "local-" prefix in order to run tests using local
browsers.

Refactored browser capabilities handling: now the used
data structures are no longer defined at module level.

QA:

Local run:
JUJU_GUI_TEST_BROWSERS="local-firefox" bin/test-charm \
    --origin=lp:~frankban/juju-gui/auth-ci-tests

Remote run:
bin/test-charm --origin=lp:~frankban/juju-gui/auth-ci-tests

https://code.launchpad.net/~frankban/juju-gui/auth-ci-tests/+merge/164768

(do not edit description out of merge proposal)

[frankban, 2013-05-20 16:52:15]

Please take a look.

[gary.poster, 2013-05-20 17:46:58]

Looks great!  QA now...

https://codereview.appspot.com/9591043/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/9591043/diff/1/app/app.js#newcode785
app/app.js:785: // the env to log out after it is navigated to make sure that
...after it has navigated...

https://codereview.appspot.com/9591043/diff/1/test/browser.py
File test/browser.py (right):

https://codereview.appspot.com/9591043/diff/1/test/browser.py#newcode123
test/browser.py:123: # Chrome because new versions come out so quickly,
therefore there
I realize this is both pre-existing and trivial. :-)

...out so quickly; therefore, there...

or

...out so quickly.  Therefore, there...

https://codereview.appspot.com/9591043/diff/1/test/test_charm_running.py
File test/test_charm_running.py (right):

https://codereview.appspot.com/9591043/diff/1/test/test_charm_running.py#newc...
test/test_charm_running.py:182: pass
why is this here?

[gary.poster, 2013-05-20 18:02:26]

One QA item that's probably separate from this branch: when test failed because
of an environment issue on my side, the environment was created but stayed up
after failure.  I expected it to have been destroyed

2013-05-20 13:50:43,368 ERROR Bad HTTPS certificate, set
'ssl-hostname-verification' to false to permit

Traceback (most recent call last):
  File "lib/deploy_charm_for_testing.py", line 218, in <module>
    sys.exit(main())
  File "lib/deploy_charm_for_testing.py", line 187, in main
    config_file.name, args.charm))
  File "lib/deploy_charm_for_testing.py", line 44, in juju
    return juju_command(*s.split())
  File "/usr/lib/python2.7/dist-packages/shelltoolbox/__init__.py", line 133, in
callable_command
    return run(*all_args)
  File "/usr/lib/python2.7/dist-packages/shelltoolbox/__init__.py", line 452, in
run
    raise exception
subprocess.CalledProcessError: Command '['juju', '-v', 'deploy',
'--environment', 'juju-gui-testing', '--config', '/tmp/tmp9vwN2v',
'cs:~juju-gui/precise/juju-gui']' returned non-zero exit status 1
Unable to deploy Charm
$ juju status --environment juju-gui-testing
2013-05-20 13:57:43,936 WARNING ssl-hostname-verification is disabled for this
environment
2013-05-20 13:57:43,936 WARNING EC2 API calls encrypted but not authenticated
2013-05-20 13:57:43,936 WARNING S3 API calls encrypted but not authenticated
2013-05-20 13:57:43,936 WARNING Ubuntu Cloud Image lookups encrypted but not
authenticated
2013-05-20 13:57:43,937 INFO Connecting to environment...
2013-05-20 13:57:46,554 INFO Connected to environment.
machines:
  0:
    agent-state: running
    dns-name: ec2-54-242-74-204.compute-1.amazonaws.com
    instance-id: i-2f49fe47
    instance-state: running
services: {}

[gary.poster, 2013-05-20 18:27:12]

LGTM, thanks!

unit tests failed for me in local firefox, but this was not the fault of your
changes.

[frankban, 2013-05-21 08:39:27]

Please take a look.

https://codereview.appspot.com/9591043/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/9591043/diff/1/app/app.js#newcode785
app/app.js:785: // the env to log out after it is navigated to make sure that
On 2013/05/20 17:46:58, gary.poster wrote:
> ...after it has navigated...

Note to self: read the comment before trying to fix it.
Thanks, done.

https://codereview.appspot.com/9591043/diff/1/test/browser.py
File test/browser.py (right):

https://codereview.appspot.com/9591043/diff/1/test/browser.py#newcode123
test/browser.py:123: # Chrome because new versions come out so quickly,
therefore there
On 2013/05/20 17:46:58, gary.poster wrote:
> I realize this is both pre-existing and trivial. :-)
> 
> ...out so quickly; therefore, there...
> 
> or
> 
> ...out so quickly.  Therefore, there...

Done.

https://codereview.appspot.com/9591043/diff/1/test/test_charm_running.py
File test/test_charm_running.py (right):

https://codereview.appspot.com/9591043/diff/1/test/test_charm_running.py#newc...
test/test_charm_running.py:182: pass
On 2013/05/20 17:46:58, gary.poster wrote:
> why is this here?

For no reason. Removed.

[frankban, 2013-05-21 08:47:33]

On 2013/05/20 18:02:26, gary.poster wrote:
> One QA item that's probably separate from this branch: when test failed
because
> of an environment issue on my side, the environment was created but stayed up
> after failure.  I expected it to have been destroyed

You are right. The base test runner is a shell script, we could use "trap" to 
ensure the env is destroyed when the script exits. Created a card.

[teknico, 2013-05-21 10:19:00]

LGTM, one trivial.

https://codereview.appspot.com/9591043/diff/3002/test/test_charm_running.py
File test/test_charm_running.py (right):

https://codereview.appspot.com/9591043/diff/3002/test/test_charm_running.py#n...
test/test_charm_running.py:212: self.wait_for_path( path, error='Post login
redirection failed.')
Stray blank after opening bracket.

[teknico, 2013-05-21 11:33:28]

Still LGTM, but while doing QA I got two errors, likely transient ones.

The first happened locally on Firefox, details:
http://pastebin.ubuntu.com/5686540/ .

The second remotely on IE, details: http://pastebin.ubuntu.com/5686626/ .

They both seem timeout errors, we'll see how things go with Jenkins.

[frankban, 2013-05-21 11:36:08]

*** Submitted:

Add authentication CI tests.

This branch introduces CI tests for the authentication 
infrastructure. Login/logout process is tested from
root and from detail pages, as discussed in a pre-imp
call with Jeff.

Fixed a bug preventing the user to logout from a detail
page if that page was directly accessed.

Also improved testing using a local Selenium driver.
As described in the docs, now it is possible to
pass a "local-" prefix in order to run tests using local
browsers.

Refactored browser capabilities handling: now the used
data structures are no longer defined at module level.

QA:

Local run:
JUJU_GUI_TEST_BROWSERS="local-firefox" bin/test-charm \
    --origin=lp:~frankban/juju-gui/auth-ci-tests

Remote run:
bin/test-charm --origin=lp:~frankban/juju-gui/auth-ci-tests

R=gary.poster, teknico
CC=
https://codereview.appspot.com/9591043

https://codereview.appspot.com/9591043/diff/3002/test/test_charm_running.py
File test/test_charm_running.py (right):

https://codereview.appspot.com/9591043/diff/3002/test/test_charm_running.py#n...
test/test_charm_running.py:212: self.wait_for_path( path, error='Post login
redirection failed.')
On 2013/05/21 10:19:00, teknico wrote:
> Stray blank after opening bracket.

Done.

[frankban, 2013-05-21 11:46:23]

Thanks both for the reviews!

On 2013/05/21 11:33:28, teknico wrote:
> Still LGTM, but while doing QA I got two errors, likely transient ones.
> 
> The first happened locally on Firefox, details:
> http://pastebin.ubuntu.com/5686540/ .
> 
> The second remotely on IE, details: http://pastebin.ubuntu.com/5686626/ .

* Details: https://saucelabs.com/jobs/4ac22d99a8b642bfa7bc423144e652df
Weird "Internet Explorer has stopped working error"...

> They both seem timeout errors, we'll see how things go with Jenkins.

In Selenium tests we mostly wait for something to happen, so it is quite usual
that failures come out as timeout errors. If there are fragilities, I hope
Jenkins will expose them and give us enough info to fix them later.