Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2216)

Issue 9590043: Fix a memory leak.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by benji
Modified:
10 years, 11 months ago
Reviewers:
mp+164765, jeff.pihach, matthew.scott
Visibility:
Public.

Description

Fix a memory leak. The toBoundingBoxes function creates a ModelList of models that are already in another list. That list laters falls out of scope, but since the models hold a reference to every list that contains them, the list is kept alive. This branch introduces code that removes the models from the temporary list after it has served its purpose. https://code.launchpad.net/~benji/juju-gui/plug-memory-leak-3/+merge/164765 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix a memory leak. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/service.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
benji
Please take a look.
10 years, 11 months ago (2013-05-20 16:20:56 UTC) #1
matthew.scott
LGTM! Thanks for finding and fixing this.
10 years, 11 months ago (2013-05-20 16:23:46 UTC) #2
jeff.pihach
LGTM Thanks for this!
10 years, 11 months ago (2013-05-20 17:27:08 UTC) #3
benji
10 years, 11 months ago (2013-05-20 18:45:08 UTC) #4
*** Submitted:

Fix a memory leak.

The toBoundingBoxes function creates a ModelList of models that are already
in another list.  That list laters falls out of scope, but since the models
hold a reference to every list that contains them, the list is kept alive.
This branch introduces code that removes the models from the temporary list
after it has served its purpose.

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/9590043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b