code review 95900044: cmd/go: go test creates many temporary directories that...

cmd/go: test: clean up all temporary directories

go test may call builder.init() multiple times which will create a new work directory.  The cleanup needs to hoist the current work directory.
Fixes issue 7904.

[mlf, 2014-04-30 14:55:32]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-04-30 16:22:06]

Please make the first line of the CL be something like

cmd/go: test: clean up all temporary directories

[iant, 2014-04-30 16:31:03]

Also: have you signed the CLA?  Thanks.

[mlf, 2014-04-30 16:31:54]

On 2014/04/30 16:31:03, iant wrote:
> Also: have you signed the CLA?  Thanks.

I sent one in earlier when I did a previous change.  I can do it again if
needed.

[iant, 2014-04-30 16:59:38]

LGTM

Thanks.

[iant, 2014-04-30 17:03:40]

*** Submitted as https://code.google.com/p/go/source/detail?r=c19d7fd53785 ***

cmd/go: test: clean up all temporary directories

go test may call builder.init() multiple times which will create a new work
directory.  The cleanup needs to hoist the current work directory.
Fixes issue 7904.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/95900044

Committer: Ian Lance Taylor <iant@golang.org>

[gobot, 2014-04-30 17:38:13]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/599ee877f2a2773bbc49ce2b917e02b8137749d5

[iant, 2014-04-30 20:48:49]

On Wed, Apr 30, 2014 at 1:38 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the netbsd-amd64-bsiegert builder.
> See http://build.golang.org/log/599ee877f2a2773bbc49ce2b917e02b8137749d5
>
> https://codereview.appspot.com/95900044/

Not really.

--- FAIL: TestNohup (3.19 seconds)
signal_test.go:205: ran test with -send_uncaught_sighup=1 under nohup
and it failed: expected success.
Error: exit status 1
Output:
--- FAIL: TestStop (1.77 seconds)
signal_test.go:28: timeout waiting for window size changes
FAIL
FAIL
FAIL os/signal 6.329s

Ian

[mlf, 2014-06-20 12:52:57]

*** Abandoned ***