code review 95870043: doc/install.html: update wrt to OS and compiler support.

doc/install.html: update wrt to OS and compiler support.
Update issue 7188
Fixes issue 7894.

[minux1, 2014-04-29 17:35:27]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[brainman, 2014-04-29 23:05:08]

https://codereview.appspot.com/95870043/diff/40001/doc/install.html
File doc/install.html (right):

https://codereview.appspot.com/95870043/diff/40001/doc/install.html#newcode50
doc/install.html:50: <tr><td>Windows XP or later</td> <td>amd64, 386</td>
<td>only mingw gcc<sup>&#8224;</sup> is supported. No need for cgywin or
msys.</td></tr>
I don's see how "only mingw gcc is supported" is better then "use mingw gcc".
Supported by who? I don's see how original is bad.

[minux1, 2014-04-30 05:44:31]

Hello golang-codereviews@googlegroups.com, alex.brainman@gmail.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[minux1, 2014-04-30 05:45:29]

On Tue, Apr 29, 2014 at 7:05 PM, <alex.brainman@gmail.com> wrote:

> https://codereview.appspot.com/95870043/diff/40001/doc/
> install.html#newcode50
> doc/install.html:50: <tr><td>Windows XP or later</td> <td>amd64,
>
> 386</td> <td>only mingw gcc<sup>&#8224;</sup> is supported. No need for
> cgywin or msys.</td></tr>
> I don's see how "only mingw gcc is supported" is better then "use mingw
> gcc". Supported by who? I don's see how original is bad.
>
Alright, I will only update the 2nd statement about cygwin and msys.

[brainman, 2014-04-30 05:58:03]

LGTM

Thank you.

(maybe wait for others for non-Windows changes)

[mikio, 2014-04-30 07:54:33]

also pls add "Update issue 7188" line to the descr

[minux1, 2014-04-30 15:37:25]

On Wed, Apr 30, 2014 at 3:54 AM, <mikioh.mikioh@gmail.com> wrote:

> also pls add "Update issue 7188" line to the descr
>
Done.

[gobot, 2014-04-30 15:37:26]

R=r@golang.org (assigned by minux.ma@gmail.com)

[bradfitz, 2014-04-30 17:19:50]

LGTM



On Wed, Apr 30, 2014 at 8:37 AM, <gobot@golang.org> wrote:

> R=r@golang.org (assigned by minux.ma@gmail.com)
>
> https://codereview.appspot.com/95870043/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[r, 2014-05-01 13:21:50]

LGTM

[minux1, 2014-05-08 05:25:31]

*** Submitted as https://code.google.com/p/go/source/detail?r=89509169b5a9 ***

doc/install.html: update wrt to OS and compiler support.
Update issue 7188
Fixes issue 7894.

LGTM=alex.brainman, bradfitz, r
R=golang-codereviews, alex.brainman, mikioh.mikioh, gobot, r, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/95870043

[gobot, 2014-05-08 05:59:25]

This CL appears to have broken the linux-386 builder.
See http://build.golang.org/log/f922836003cff09705b2cafd9ed16ec9f2245b0e

[minux1, 2014-05-08 06:12:59]

On Thu, May 8, 2014 at 1:59 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the linux-386 builder.
> See http://build.golang.org/log/f922836003cff09705b2cafd9ed16ec9f2245b0e

No.

# GOMAXPROCS=2 runtime -cpu=1,2,4
--- FAIL: TestStackGrowth-4 (20.73 seconds)
stack_test.go:166: finalizer did not run
FAIL
FAIL runtime 49.867s
Build complete, duration 3m15.887204312s. Result: error: exit status 1